Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to mulitple entrypoints #34162

Open
sjindel-google opened this issue Aug 16, 2018 · 8 comments
Open

Improvements to mulitple entrypoints #34162

sjindel-google opened this issue Aug 16, 2018 · 8 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. triaged Issue has been triaged by sub team

Comments

@sjindel-google
Copy link
Contributor

sjindel-google commented Aug 16, 2018 •
edited
Loading

This task is primarily an anchor for associated "TODO"s in the code. Mainly, ARM64/IA32 support is missing.
@sjindel-google sjindel-google added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Aug 16, 2018
@sjindel-google sjindel-google self-assigned this Aug 16, 2018
@sjindel-google sjindel-google added the P3 A lower priority bug or feature request label Aug 27, 2018
@mraleph
Copy link
Member

mraleph commented Jan 8, 2019

I think it makes sense to enable multiple entry points on all architectures we support to avoid confusing non-symmetry. Bumping priority to P1 for this particular task.

@mraleph mraleph added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P3 A lower priority bug or feature request labels Jan 8, 2019
@mraleph
Copy link
Member

mraleph commented Apr 11, 2019 •
edited
Loading

We are wasting space in generated code because of incomplete implementation - we don't stop code generation when TryIntrinsify returns true when called from FunctionEntryInstr::EmitNativeCode - this negates some of the @mkustermann work to reduce size of method extractors.

@sjindel-google
Copy link
Contributor Author

AOT is done, only the ARM64/IA32 support is missing.

@a-siva
Copy link
Contributor

a-siva commented May 24, 2019

Does this still need to be labeled p1-high (that usually means "Planned for the in-progress release"). Can we mark it as 'p2-medium'

@mraleph mraleph added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels May 27, 2019
@sjindel-google
Copy link
Contributor Author

Note that the exactness checking in the IC stubs is only implemented on x64.

dart-bot pushed a commit that referenced this issue Dec 19, 2019
@sjindel-google
[vm] Enable multiple entry-points on ARM64.
f134164 
Adresses #34162

Change-Id: I7126f8c9b470041aaa260255293327f67d64d1bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128063
Commit-Queue: Samir Jindel <[email protected]>
Reviewed-by: Martin Kustermann <[email protected]>
dart-bot pushed a commit that referenced this issue Jan 7, 2020
@sjindel-google
[vm] Enable multiple entry-points on IA32.
8a39cb8 
Issue #34162

Change-Id: If3ca8448012dd1e3dc6e5f638e24202f53ccaf60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129716
Commit-Queue: Samir Jindel <[email protected]>
Reviewed-by: Martin Kustermann <[email protected]>
tekknolagi pushed a commit to tekknolagi/dart-assembler that referenced this issue Nov 3, 2020
@sjindel-google
[vm] Enable multiple entry-points on ARM64.
fb7e926 
Adresses dart-lang#34162

Change-Id: I7126f8c9b470041aaa260255293327f67d64d1bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128063
Commit-Queue: Samir Jindel <[email protected]>
Reviewed-by: Martin Kustermann <[email protected]>
tekknolagi pushed a commit to tekknolagi/dart-assembler that referenced this issue Nov 3, 2020
@sjindel-google
[vm] Enable multiple entry-points on IA32.
dd6f8b2 
Issue dart-lang#34162

Change-Id: If3ca8448012dd1e3dc6e5f638e24202f53ccaf60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129716
Commit-Queue: Samir Jindel <[email protected]>
Reviewed-by: Martin Kustermann <[email protected]>
@a-siva
Copy link
Contributor

a-siva commented Aug 5, 2022

//cc @mkustermann is there more to be done on this issue or can we close it ?

@a-siva a-siva removed the P2 A bug or feature request we're likely to work on label Nov 4, 2022
@a-siva
Copy link
Contributor

a-siva commented Nov 4, 2022

//cc @alexmarkov I am presuming this has been implemented on all the architectures we care about, can this be closed?
(removing p2 label).

@alexmarkov
Copy link
Contributor

There are still a few TODOs referencing this issue in the VM source code. So we can leave this issue open until those TODOs are addressed or cleaned up.

@a-siva a-siva added triaged Issue has been triaged by sub team and removed vm-triaged labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mraleph @mkustermann @a-siva @alexmarkov @sjindel-google