Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co19/Language/Classes/definition_t23 test fails (to compile with frontend) #31624

Closed
aam opened this issue Dec 13, 2017 · 2 comments
Closed

co19/Language/Classes/definition_t23 test fails (to compile with frontend) #31624

aam opened this issue Dec 13, 2017 · 2 comments
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.

Comments

@aam
Copy link
Contributor

aam commented Dec 13, 2017

FAILED: dartk-vm release_x64 co19/Language/Classes/definition_t23
Expected: Pass
Actual: CompileTimeError

--- Command "vm" (took 571ms):
DART_CONFIGURATION=ReleaseX64 xcodebuild/ReleaseX64/dart --dfe=xcodebuild/ReleaseX64/gen/kernel-service.dart.snapshot --kernel-binaries=xcodebuild/ReleaseX64 --ignore-unrecognized-flags --packages=/Users/aam/projects/dart/sdk/.packages /Users/aam/projects/dart/sdk/tests/co19/src/Language/Classes/definition_t23.dart

exit code:
254

stderr:
'file:///Users/aam/projects/dart/sdk/tests/co19/src/Language/Classes/definition_t23.dart': error: line 28 pos 21: super type 'A1' may not be listed in implements clause of class 'I3'
@A() abstract class I3<T> = A1 with B1 implements A1;
                    ^

--- Re-run this test:
python tools/test.py -m release -c dartk co19/Language/Classes/definition_t23

It sounds like a legitimate compilation error though.

@aam aam added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Dec 13, 2017
@lrhn
Copy link
Member

lrhn commented Dec 13, 2017

The supertype of I3<T> is A1, and the class also implements A1. The spec does indeed say:

It is a compile-time error if the superclass of a class C is specified as a superinterface of C.

(It should just say "as an interface of C", but otherwise it's pretty clear).

@kmillikin
Copy link

So there's a bug in the source-based VM because it's missing the compile time error, and there's a bug in the co19 test itself. But this is not a bug in the front end (nor Analyzer nor dart2js, judging from their co19 status files which all have CompileTimeError).

I filed dart-lang/co19#129 against co19. I assume the issue in the source-based VM will be won't fixed, so I'm not going to file it. (Feel free to file an issue if you disagree.)

dart-bot pushed a commit that referenced this issue Mar 6, 2018
The only change in co19-runtime.status that isn't just combining two
sections and normalizing is the movement of

Language/Classes/definition_t24: MissingCompileTimeError # Issue co19 #129, sdk issue #31624

from the vm section to a section with vm, dart_precompiled, and flutter, and
the removal of two sections only containing a single Generative_Constructors
test each.

The file is also normalized.

Bug: dartbug.com/32434
Change-Id: Ic62817b3ebdfd27e3cd58abc21f8bd61e7a18664
Reviewed-on: https://dart-review.googlesource.com/45380
Reviewed-by: Peter von der Ahé <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.
Projects
None yet
Development

No branches or pull requests

3 participants