Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart:html Storage interface has wrong MDN docs #3090

Closed
sethladd opened this issue May 16, 2012 · 9 comments
Closed

dart:html Storage interface has wrong MDN docs #3090

sethladd opened this issue May 16, 2012 · 9 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@sethladd
Copy link
Contributor

http://api.dartlang.org/html/Storage.html

It incorrectly lists Storage as "Storage is a SQLite database API. It is available to trusted callers, meaning extensions and Firefox components only."

@munificent
Copy link
Member

Added this to the Later milestone.

@sethladd
Copy link
Contributor Author

sethladd commented Jun 6, 2012

Sorry, I disagree. This is M1, we're showing incorrect docs now.


Removed this from the Later milestone.
Added this to the M1 milestone.

@sethladd
Copy link
Contributor Author

Hi Alex,

Can you add some simple docs so the incorrect MDN notes won't appear here?

Thanks!


Set owner to [email protected].

@sethladd
Copy link
Contributor Author

Bumping to high and assigning to Kathy.

Kathy, can you at minimum remove the MDN doc for this interface, and add a few lines as to what Storage is? It's basically a Map for local storage.

Thanks!


Set owner to @kwalrath.
Removed Priority-Medium label.
Added Priority-High label.

@kwalrath
Copy link
Contributor

Added Started label.

@kwalrath
Copy link
Contributor

We added intro comments to Storage and WebSocket June 26 (r9146). In fact, you can still see the good versions at http://kathy-02.dartlang-api.appspot.com/html/Storage.html and http://kathy-02.dartlang-api.appspot.com/html/WebSocket.html.

So this seems like a doc generation issue. Vijay, could you take a look?


Set owner to @vsmenon.
Added Accepted label.

@vsmenon
Copy link
Member

vsmenon commented Aug 20, 2012

Eli - should get this for free when you fix apidoc.


Set owner to [email protected].
Added Triaged label.

@DartBot
Copy link

DartBot commented Sep 7, 2012

This comment was originally written by [email protected]


https://chromiumcodereview.appspot.com/10918112 will cover this.

@DartBot
Copy link

DartBot commented Sep 10, 2012

This comment was originally written by [email protected]


Added Fixed label.

@sethladd sethladd added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Sep 10, 2012
@sethladd sethladd added this to the M1 milestone Sep 10, 2012
copybara-service bot pushed a commit that referenced this issue Jul 19, 2022
…5 revisions)

https://dart.googlesource.com/dartdoc/+log/ff89da1c9831..e6c8861ad355

2022-07-19 [email protected] Remove MatchingLinkResult.warn; unused (#3090)
2022-07-19 [email protected] Make ContainerMember.enclosingElement a Container (#3085)
2022-07-19 [email protected] Make ModelElement fields library and package non-nullable (#3086)
2022-07-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/cache from 3.0.4 to 3.0.5 (#3087)
2022-07-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.1.15 to 2.1.16 (#3088)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I37a4e3811b01ada3f425f7404ba13698c7f0a085
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251922
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

5 participants