-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistent null value in dart:js #20305
Comments
fix on its way: https://codereview.chromium.org/437733002/ Added Started label. |
r38814 Added Fixed label. |
Issue #20280 has been merged into this issue. |
2 similar comments
Issue #20280 has been merged into this issue. |
Issue #20280 has been merged into this issue. |
This comment was originally written by [email protected] Eagerly awaiting a fix here. This bug means I simply can't build my app. Even with the workaround mentioned in https://code.google.com/p/dart/issues/detail?id=20280, it remains broke on Safari. And all I did was upgrade to the newly released Polymer. |
Issue #20336 has been merged into this issue. |
Issue #20280 has been merged into this issue. |
Issue #19591 has been merged into this issue. |
This comment was originally written by [email protected] Is the best way to know when a new SDK is released to monitor https://gsdview.appspot.com/dart-archive/channels/dev/raw/latest/sdk/ for a more recent timestamp? |
probably you want to look at https://gsdview.appspot.com/dart-archive/channels/dev/release/latest/sdk/ ('release' instead of 'raw') There are very similar, except that 'raw' contains any build we make, 'release' are the ones that we send out after validating that all tests pass. The editor auto-upgrades when a new SDK is out on 'release'. The latest 'raw' already has the fix for this specific bug. I expect it will get promoted as 'released' very soon. |
This comment was originally written by [email protected] Noted. And grrr... w/ the raw or even release of dev, pub build fails with: Can't read 'package:woven/config/config.dart' (Could not find asset woven|lib/config/config.dart.). Did something change with respect to package imports? |
Set owner to @sigmundch. |
Hey Dave - sorry for not getting back to you earlier on the config.dart issue. It sounds like a bug, but it's not obvious to me what's going on (it could be in our transformers, or in pub itselfs, hard to say). If you haven't already, please file a separate bug for it. |
This comment was originally written by [email protected] Done: https://code.google.com/p/dart/issues/detail?id=20512&thanks=20512&ts=1407979533 |
The dart:js library behaves differently in Dartium or dart2js when sending a null value. In Dartium, the value is sent as 'null'. In dart2js it is sent as undefined.
They should be consistent.
Here is a sample test:
import 'dart:js';
main() {
context['console'].callMethod('log', [null]);
}
Whether they should be null or undefined, is a good question. I have a use case where I'd prefer for it to be null, but there might be cases suggesting the opposite.
Alternatively, there should be an option in dart:js to choose one or the other.
The text was updated successfully, but these errors were encountered: