-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS version of polymer chessboard app does not work #20280
Comments
This comment was originally written by [email protected] The following error can be seen in the Chrome console window: |
Removed Priority-Unassigned label. |
Seems like a bug in the polymer.js logic here: I'll try to create a small test case for them, but I was able to validate that just changing if (p.element) to: if (p && p.element) fixes the issue. I'll create a change for them and keep you posted. meanwhile, if you need to make progress, you can edit your local copy of polymer.html to load polymer.concat.js, and change polymer.concat.js with the patch above. Added Started label. |
This comment was originally written by @kaendfinger I have this issue as well. Any chance it will be done tonight? This big has set me back quite a bit today :P |
I've been looking more into it, and I can't reproduce it on Javascript alone. The polymer code works if the name of the base class is 'null' rather than 'undefined'. It looks like the issue is in our dart:js layer. dart:js is assuming that null values are 'undefined' in Javascript, but in this case, we need to actually use 'null'. |
Indeed - it's a bug from dart:js. See issue #20305. I'll send a patch for dart:js shortly, but that wont be available until the next build of the -dev channel of the SDK |
The fix is now submitted in r38814. As soon as the next dev build is released this should work again. Meanwhile, one way to work around this is to edit your copy of polymer.js under packages/polymer/src/js/polymer/polymer.js and change this portion: to: |
Another way to fix this is to edit the output of pub-build. The app_bootstrap.dart.js will have a portion like this: if(a==null)return Changing it to add if(a==null)return null |
This comment was originally written by [email protected] I'm having the same problem and I don't find any code portion looks like that. When shall we expect the next dev channel release? Both this issue and issue of pub version conflict with Polymer should be addressed soon |
the bots finished building the next release, I expect it will be released after some testing early next week. |
This comment was originally written by [email protected] Siggi's suggestion in #7 let me build so it runs in Chrome, but it remains broken in Safari with: http://d.pr/i/I3Lz See http://mycommunity.org for a live example (running on GCE by the way!). |
This comment was originally written by [email protected] Confirming that the suggestion in #8 had the same effect: works in Chrome, does not work in Safari: [Error] Element name could not be inferred. |
Hey Dave, cool to see the live example! :) - It sounds like the issue you see in Safari is something unrelated though. I've opened a separate bug to track that here: https://code.google.com/p/dart/issues/detail?id=20354 If you have an example we can build locally that runs into the error, could you please post it there? Thanks! |
This comment was originally written by [email protected] Hi Siggi. Pull and checkout the Dev branch at |
This issue has been moved to dart-archive/polymer-dart#254. |
This issue was originally filed by [email protected]
What steps will reproduce the problem?
What is the expected output? What do you see instead?
The expected output is the chessboard as when running in Dartium.
(in Dartium it works fine, except some text appears briefly before the expected content appears)
What version of the product are you using?
Dart Editor version 1.6.0.dev_06_00
Dart SDK version 1.6.0-dev.6.0
On what operating system?
Mac OSX 10.9.4
What browser (if applicable)?
Chrome 36.0.1985.125
Please provide any additional information below.
The text was updated successfully, but these errors were encountered: