frogsh: multiline string constants don't handle embedded escaped quote marks correctly #1002
Labels
Comments
|
Removed Area-Frog label. |
|
Added WontFix label. |
kevmoo
added
closed-not-planned
dart-bot
pushed a commit
that referenced
this issue
Feb 22, 2021
2021-02-22 [email protected] Fix syntax error in test expectation in ffi test (#1002) 2021-02-20 [email protected] #1000: Missing Issue tags added. 2021-02-20 [email protected] Issue #1000: tests updated according to the recent result analysis 2021-02-20 [email protected] Roll failures fixed 2021-02-19 [email protected] #999. Missed experiment flags added 2021-02-19 [email protected] #993. 32 and 64-bit integer tests added 2021-02-19 [email protected] #993. Change test to expect compile error if struct subclass created by the constructor 2021-02-19 [email protected] #993. Remove tests that run "nm" command 2021-02-18 [email protected] #993. More ffi tests added 2021-02-18 [email protected] Instantiate-to-bounds tests apdated according to the SDK Issues 44223, 42446 evaluation. 2021-02-17 [email protected] Issue #535: nnbd-strong requirement added to the tests, more tests for constant evaluation and canonicalization added. 2021-02-17 [email protected] Some of type aliases tests fixed 2021-02-17 [email protected] #993. More Struct tests added 2021-02-16 [email protected] Issue #535: more tests for constant evaluation and canonicalization added. 2021-02-12 [email protected] Fixes #994: test expectesions updated according to the recent SDK changes. 2021-02-12 [email protected] #993. More Struct tests added 2021-02-12 [email protected] Merge remote-tracking branch 'origin/master' 2021-02-12 [email protected] #993. NativeType and Struct tests added 2021-02-11 [email protected] Fixes #991: tests updated according to the recent SDK changes. 2021-02-08 [email protected] #993. sizeOf() tests added 2021-02-05 [email protected] #993. More tests for DynamicLibrary added 2021-02-04 [email protected] #993. DynamicLibrary constructors tests added 2021-02-03 [email protected] #993. co19 ffi tests. Initial commit 2021-02-02 [email protected] Fixes #992. Boolean conditional evaluation tests added 2021-02-01 [email protected] Fixes #990: tests updated according to the recent SDK changes. 2021-01-28 [email protected] Fixes #979: I-2-b tests updated according to the recent changes for dart-lang/language#1133 2021-01-28 [email protected] Fixes #984: I-2-b tests updated according to the recent changes for dart-lang/language#1133 2021-01-27 [email protected] Fixes #989. Runtime type equality operator tests added 2021-01-26 [email protected] Fixes #988: Static warning checks corrected. 2021-01-25 [email protected] Fixes #987. Local variables and inference tests added Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-mac-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-mac-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-ia32-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-nnbd-win-release-ia32-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: I78ba37f9c74d2afc360ef5fbd51d01ab75239fd6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186146 Reviewed-by: Jonas Termansen <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by [email protected]
Repro steps:
frogsh bug.dart
Expected:
Prints """z"""
Actual:
node.js:201
throw e; // process.nextTick error, or 'error' event on first tick
^
SyntaxError: Unexpected token ILLEGAL
at minfrog_main (/Users/jackpal/code/dart/dart/frog/xcodebuild/Release_ia32/frog/bin/frogsh:26440:10)
at main (/Users/jackpal/code/dart/dart/frog/xcodebuild/Release_ia32/frog/bin/frogsh:26451:3)
at Object.<anonymous> (/Users/jackpal/code/dart/dart/frog/xcodebuild/Release_ia32/frog/bin/frogsh:26951:1)
at Module._compile (module.js:432:26)
at Object..js (module.js:450:10)
at Module.load (module.js:351:31)
at Function._load (module.js:310:12)
at Array.0 (module.js:470:10)
at EventEmitter._tickCallback (node.js:192:40)
Attachment:
bug.dart (236 Bytes)
The text was updated successfully, but these errors were encountered: