[vm] Restore InstanceKind.TypeRef in the VM-service API for backwards…

… compatibility

TEST=doc/comment change
Change-Id: I0fcb9d418a9c95e6ce57a03eb693aefb9e245d2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301501
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Alexander Markov <[email protected]>

pkg/vm_service/lib/src/vm_service.dart

@@ -2960,7 +2960,8 @@ class InstanceKind {
   /// An instance of the Dart class TypeParameter.
   static const String kTypeParameter = 'TypeParameter';
 
-  /// An instance of the Dart class TypeRef.
+  /// An instance of the Dart class TypeRef. Note: this object kind is
+  /// deprecated and will be removed.
   static const String kTypeRef = 'TypeRef';
 
   /// An instance of the Dart class FunctionType.
@@ -4637,8 +4638,8 @@ class FieldRef extends ObjRef {
 
   /// The declared type of this field.
   ///
-  /// The value will always be of one of the kinds: Type, TypeRef,
-  /// TypeParameter, BoundedType.
+  /// The value will always be of one of the kinds: Type, TypeParameter,
+  /// RecordType, FunctionType, BoundedType.
   InstanceRef? declaredType;
 
   /// Is this field const?
@@ -4732,8 +4733,8 @@ class Field extends Obj implements FieldRef {
 
   /// The declared type of this field.
   ///
-  /// The value will always be of one of the kinds: Type, TypeRef,
-  /// TypeParameter, BoundedType.
+  /// The value will always be of one of the kinds: Type, TypeParameter,
+  /// RecordType, FunctionType, BoundedType.
   @override
   InstanceRef? declaredType;
 
@@ -5747,22 +5748,20 @@ class Instance extends Obj implements InstanceRef {
   @optional
   int? parameterIndex;
 
-  /// The type bounded by a BoundedType instance - or - the referent of a
-  /// TypeRef instance.
+  /// The type bounded by a BoundedType instance.
   ///
-  /// The value will always be of one of the kinds: Type, TypeRef,
-  /// TypeParameter, BoundedType.
+  /// The value will always be of one of the kinds: Type, TypeParameter,
+  /// RecordType, FunctionType, BoundedType.
   ///
   /// Provided for instance kinds:
   ///  - BoundedType
-  ///  - TypeRef
   @optional
   InstanceRef? targetType;
 
   /// The bound of a TypeParameter or BoundedType.
   ///
-  /// The value will always be of one of the kinds: Type, TypeRef,
-  /// TypeParameter, BoundedType.
+  /// The value will always be of one of the kinds: Type, TypeParameter,
+  /// RecordType, FunctionType, BoundedType.
   ///
   /// Provided for instance kinds:
   ///  - BoundedType
@@ -8666,8 +8665,8 @@ class TypeArguments extends Obj implements TypeArgumentsRef {
 
   /// A list of types.
   ///
-  /// The value will always be one of the kinds: Type, TypeRef, TypeParameter,
-  /// BoundedType.
+  /// The value will always be one of the kinds: Type, TypeParameter,
+  /// RecordType, FunctionType, BoundedType.
   List<InstanceRef>? types;
 
   TypeArguments({

runtime/vm/service/service.md

@@ -3330,6 +3330,10 @@ enum InstanceKind {
   // An instance of the Dart class TypeParameter.
   TypeParameter,
 
+  // An instance of the Dart class TypeRef.
+  // Note: this object kind is deprecated and will be removed.
+  TypeRef,
+
   // An instance of the Dart class FunctionType.
   FunctionType,