fixes #197, don't generate casts that always pass

[email protected] Review URL: https://codereview.chromium.org/1261783005 .
dart-lang · Aug 4, 2015 · b393e12 · b393e12
1 parent 8422d7a
commit b393e12
Show file tree

Hide file tree

Showing 5 changed files with 257 additions and 254 deletions.
diff --git a/pkg/dev_compiler/lib/src/codegen/js_codegen.dart b/pkg/dev_compiler/lib/src/codegen/js_codegen.dart
@@ -253,6 +253,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
     var from = getStaticType(node.expression);
     var to = node.type.type;
 
+    // Skip the cast if it's not needed.
+    if (rules.isSubTypeOf(from, to)) return _visit(node.expression);
+
     // All Dart number types map to a JS double.
     if (rules.isNumType(from) &&
         (rules.isIntType(to) || rules.isDoubleType(to))) {