Skip to content

Commit

Permalink
enhanced enum tests for avoid_renaming_method_parameters (dart-lang…
Browse files Browse the repository at this point in the history
…/linter#3188)

* enhanced enum tests for `avoid_renaming_method_parameters`

* => implements
  • Loading branch information
pq authored Jan 30, 2022
1 parent cbb8e30 commit 57885e0
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test/rules/all.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import 'avoid_function_literals_in_foreach_calls.dart'
import 'avoid_init_to_null.dart' as avoid_init_to_null;
import 'avoid_redundant_argument_values.dart'
as avoid_redundant_argument_values;
import 'avoid_renaming_method_parameters.dart'
as avoid_renaming_method_parameters;
import 'avoid_returning_this.dart' as avoid_returning_this;
import 'avoid_shadowing_type_parameters.dart'
as avoid_shadowing_type_parameters;
Expand Down Expand Up @@ -59,6 +61,7 @@ void main() {
avoid_function_literals_in_foreach_calls.main();
avoid_init_to_null.main();
avoid_redundant_argument_values.main();
avoid_renaming_method_parameters.main();
avoid_returning_this.main();
avoid_shadowing_type_parameters.main();
avoid_types_as_parameter_names.main();
Expand Down
40 changes: 40 additions & 0 deletions test/rules/avoid_renaming_method_parameters.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'package:test_reflective_loader/test_reflective_loader.dart';

import '../rule_test_support.dart';

main() {
defineReflectiveSuite(() {
defineReflectiveTests(AvoidRenamingMethodParametersTest);
});
}

@reflectiveTest
class AvoidRenamingMethodParametersTest extends LintRuleTest {
@override
List<String> get experiments => [
EnableString.enhanced_enums,
];

@override
String get lintRule => 'avoid_renaming_method_parameters';

@FailingTest(issue: 'https://github.com/dart-lang/linter/issues/3095')
test_rename() async {
await assertDiagnostics(r'''
class C {
int f(int f) => f;
}
enum A implements C {
a,b,c;
@override
int f(int x) => x;
}
''', [
lint('avoid_renaming_method_parameters', 28, 8), // todo(pq): update index
]);
}
}

0 comments on commit 57885e0

Please sign in to comment.