Remove support for legacy credentials file #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Mar 15, 2023
lib/src/oauth2.dart
Outdated
| /// best place for storing secrets, as it might be shared. | ||
| /// | ||
| /// To provide backwards compatibility we use the legacy file if only it exists. | ||
| /// | ||
| /// Returns `null` if there is no good place for the file. | ||
| String? _credentialsFile(SystemCache cache) { |
There was a problem hiding this comment.
We don't need SystemCache as argument
There was a problem hiding this comment.
Good catch. Removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stopped creating this in dart 2.15
https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md#pub-4
One might say we should support this longer - but I think Dart 3.0 is a good place to make this change. And also the consequence is only the user would have to log in again.