Warn about publishing in mixed mode #2583
Conversation
The null-safety analysis now rejects any package that doesn't opt-in before doing resolution. This is reflected in this test.
| @@ -445,6 +446,17 @@ class Pubspec { | |||
| bool get isEmpty => | |||
| name == null && version == Version.none && dependencies.isEmpty; | |||
|
|
|||
| /// The language version implied by the sdk constraint. | |||
| /// | |||
| /// Given no or unbounded constraint we assume language version 1.0. | |||
There was a problem hiding this comment.
Is this correct?
Doesn't the spec say that the fallback language version is the whatever the current SDK has?
I can see that this might cause validation errors if you have no SDK constraint..
There was a problem hiding this comment.
pub.dev treats packages with no constraint as dart 1 packages, so at least for null-safety checking I think this makes sense. We might have to revise later.
lib/src/null_safety_analysis.dart
Outdated
| .languageVersion; | ||
| if (!rootLanguageVersion.supportsNullSafety) { | ||
| return NullSafetyAnalysisResult( | ||
| NullSafetyCompliance.notCompliant, 'Is not opting in to null safety'); |
There was a problem hiding this comment.
Can we be more specific? Like "Package $packageId has not opted into null-safety with the environment.sdk constraint in pubspec.yaml", or something like it.
There was a problem hiding this comment.
I added SourceSpans highlighting the problem
| final NullSafetyCompliance compliance; | ||
|
|
||
| /// `null` if compliance == [NullSafetyCompliance.compliant]. | ||
| final String reason; |
There was a problem hiding this comment.
Love it, we might even want to output this in the JSON output from pub outdated.
lib/src/null_safety_analysis.dart
Outdated
| final languageVersion = pubspec.languageVersion; | ||
| if (languageVersion == null || !languageVersion.supportsNullSafety) { | ||
| return NullSafetyAnalysisResult(NullSafetyCompliance.notCompliant, | ||
| 'package:${dependencyId.name} is not opted into null safety'); |
There was a problem hiding this comment.
Again, can we say something with environment.sdk in pubspec.yaml
There was a problem hiding this comment.
I added SourceSpans highlighting the problem
lib/src/null_safety_analysis.dart
Outdated
| if (!languageVersion.supportsNullSafety) { | ||
| return NullSafetyAnalysisResult( | ||
| NullSafetyCompliance.notCompliant, | ||
| '$fileUrl is opting out of null safety'); |
There was a problem hiding this comment.
| '$fileUrl is opting out of null safety'); | |
| '$fileUrl is opting out of null-safety with language version marker $languageVersionToken'); |
There was a problem hiding this comment.
I added SourceSpans highlighting the problem
lib/src/null_safety_analysis.dart
Outdated
| .languageVersion; | ||
| if (!rootLanguageVersion.supportsNullSafety) { | ||
| return NullSafetyAnalysisResult( | ||
| NullSafetyCompliance.notCompliant, 'Is not opting in to null safety'); |
There was a problem hiding this comment.
I added SourceSpans highlighting the problem
lib/src/null_safety_analysis.dart
Outdated
| final languageVersion = pubspec.languageVersion; | ||
| if (languageVersion == null || !languageVersion.supportsNullSafety) { | ||
| return NullSafetyAnalysisResult(NullSafetyCompliance.notCompliant, | ||
| 'package:${dependencyId.name} is not opted into null safety'); |
There was a problem hiding this comment.
I added SourceSpans highlighting the problem
lib/src/null_safety_analysis.dart
Outdated
| if (!languageVersion.supportsNullSafety) { | ||
| return NullSafetyAnalysisResult( | ||
| NullSafetyCompliance.notCompliant, | ||
| '$fileUrl is opting out of null safety'); |
There was a problem hiding this comment.
I added SourceSpans highlighting the problem
#2438