Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub: installed name should be based on pubspec name, not URL #47

Closed
DartBot opened this issue Jun 5, 2015 · 3 comments
Closed

Pub: installed name should be based on pubspec name, not URL #47

DartBot opened this issue Jun 5, 2015 · 3 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

Originally opened as dart-lang/sdk#3494

This issue was originally filed by [email protected]


My pubspec looks like:

name: 'googlefoo-samples'
dependencies:
  googlefoo:
    git: https://code.google.com/p/google-foo-dart-client

The intent being to import as #import('package:googlefoo/...');
However this gets installed as packages/google-foo-dart-client, and can only be imported as 'package:google-foo-dart-client/...'.
Since the names are specified in the pubspec, is there any reason not to use them?

(I can't change the project name, it's a cross-language convention).

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) wontfix labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl


Added Area-Pub, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Added this to the M1 milestone.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Pub now requires the name in the pubspec to match the name extracted from the Git repo. Allowing the sort of renaming suggested in this issue would break transitive dependencies.


Added WontFix label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants