Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/fix markdown alert blocks + style rules. #8181

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Oct 23, 2024

  • Supports GitHub Alerts with Markdown #7278
  • styles rules and colors are copied from dartdoc verbatim
  • pushed to staging for verification
  • I think we should update the colors and styles, merging them with the already existing pub.dev styles. However I don't think it is worth to block the feature on it, it can be done after this is landed.
  • I've commented out the icon block for now, adding a TODO to resolve it later, as pub.dev does not use Material Symbols Outlined fonts, as traditionally we've copied the required fonts into the static image directory. Let's discuss which direction we want to take.

@isoos isoos requested review from jonasfj and sigurdm October 23, 2024 15:59
@isoos
Copy link
Collaborator Author

isoos commented Oct 23, 2024

/cc @parlough

@isoos isoos merged commit acc9d06 into dart-lang:master Oct 25, 2024
32 checks passed
@isoos isoos deleted the markdown-alerts branch October 25, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants