Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Linux X64 toolchain for non-X64 hosts. #164

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Setup Linux X64 toolchain for non-X64 hosts. #164

merged 1 commit into from
Oct 26, 2023

Conversation

rmacnak-google
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 25, 2023

Coverage Status

coverage: 98.076% (-0.1%) from 98.179% when pulling fac2741 on rmacnak-google:linux-x64 into d79a7cd on dart-lang:main.

@dcharkes
Copy link
Collaborator

Can you check if GitHub actions provides arm64 linux bots on which we could get code coverage for this?

Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like GitHub actions does not have linux_arm64 bots (unless we self-host). So approval granted to land without coverage.

Side note: the tests are also run on the Dart CI in:

  • pkg-linux-debug-try
  • pkg-linux-release-try
  • pkg-mac-release-arm64-try
  • pkg-mac-release-try
  • pkg-win-release-try

It would be lovely if we could get a pkg-linux-release-arm64 and pkg-windows-release-arm64 there. (cc @pbo-linaro who wants to contribute win arm64 support flutter/flutter#129807 )

@@ -29,6 +29,15 @@ final i686LinuxGnuGccAr = _gnuArchiver('i686-linux-gnu');
/// [gnuLinker] with [Tool.defaultResolver] for [Architecture.ia32].
final i686LinuxGnuLd = _gnuLinker('i686-linux-gnu');

/// [gcc] with [Tool.defaultResolver] for [Architecture.x64].
final x86_64LinuxGnuGcc = _gcc('x86_64-linux-gnu');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens on x64 hosts? Can one install the x86_64-linux-gnu-gcc on an x64 host? If so, will it be an alias for gcc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On an X64 Debian machine, if I install g++ I get both /usr/bin/g++ and /usr/bin/x86_64-linux-gnu-g++.

@rmacnak-google
Copy link
Contributor Author

Can you check if GitHub actions provides arm64 linux bots on which we could get code coverage for this?

I think Mac ARM64 is in beta, Linux and Windows ARM64 don't exist unless one provides their own runner.

It would be lovely if we could get a pkg-linux-release-arm64 and pkg-windows-release-arm64 there. (cc @pbo-linaro who wants to contribute win arm64 support flutter/flutter#129807 )

I already have outstanding CLs to set those up :)

@pbo-linaro
Copy link
Contributor

@rmacnak-google Do you mean you have a port for windows-arm64? I started looking at this today, but if you already have it somewhere, I'm willing to test it.

@rmacnak-google
Copy link
Contributor Author

@pbo-linaro I mean that I have changes to Dart infrastructure that would enable testing for certain Dart packages, such as the ones in this repository, for Linux and Windows ARM64 like we already have for Linux/Mac/Windows X64 and Mac ARM64. I do not have changes that setup the Windows ARM64 toolchain for the packages in this repository.

@rmacnak-google rmacnak-google merged commit 18bff8c into dart-lang:main Oct 26, 2023
18 checks passed
@dcharkes
Copy link
Collaborator

It would be lovely if we could get a pkg-linux-release-arm64 and pkg-windows-release-arm64 there. (cc @pbo-linaro who wants to contribute win arm64 support flutter/flutter#129807 )

I already have outstanding CLs to set those up :)

Sweet! Thanks Ryan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants