Widen argument type of Mock.operator ==
#718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_582683687
branch
from
a45c373 to
f99e5ee
Compare
When mocking a class `C` we say `Mock implements C` so for this to compile `Mock` has to be a valid implementation of `C`. This wasn't the case for classes with an overridden `operator ==` that accepts `dynamic` or `Object?`. Widen the `Mock.operator ==` argument's type to accomodate for this case. PiperOrigin-RevId: 582683687
copybara-service
bot
force-pushed
the
test_582683687
branch
from
f99e5ee to
f88618d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widen argument type of
Mock.operator ==When mocking a class
Cwe sayMock implements Cso forthis to compile
Mockhas to be a valid implementation ofC.This wasn't the case for classes with an overridden
operator ==thataccepts
dynamicorObject?. Widen theMock.operator ==argument'stype to accomodate for this case.