This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Add redirects and specify canonical URLs pointing to dart.dev #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Jun 28, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 1 in retiring the old linter site. Using
http-equivit redirects from the generated pages to their dart.dev equivalents. It also specifies a canonical URL to clearly signal to search engines that the content has moved.Eventually we'll be able to cleanup and eventually disable the automatic generation, but this gets the redirects functional immediately.
I've staged a version of the site generated with these changes. Visit the below links to see the redirects functional:
Staged rule index page: https://parlough-linter.web.app/lints/index.html
Staged rule page: https://parlough-linter.web.app/lints/prefer_final_fields.html
Staged all rule list: https://parlough-linter.web.app/lints/options/options.html
Contributes to dart-lang/sdk#59186 and dart-lang/site-www#4499