This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
migrate avoid_null_checks_in_equality_operators away from traverseNodesInDFS()
#3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
linter-set-recommended
pq
changed the title
traverseNodesInDFS()avoid_null_checks_in_equality_operators away from traverseNodesInDFS()
bwilkerson
approved these changes
Sep 22, 2022
|
Pretty cheap already, but I can imagine generated code which may create classes with equality operators with many checks inside. Protos, etc. |
srawlins
approved these changes
Sep 22, 2022
Exactly. This was the lesson of dart-lang/sdk#58881 |
12 tasks
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
/cc @bwilkerson @srawlins