Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

enhanced enum support for unnecessary_getters_setters #3204

Merged
merged 1 commit into from
Jan 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/src/rules/unnecessary_getters_setters.dart
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class UnnecessaryGettersSetters extends LintRule {
NodeLintRegistry registry, LinterContext context) {
var visitor = _Visitor(this);
registry.addClassDeclaration(this, visitor);
registry.addEnumDeclaration(this, visitor);
}
}

Expand All @@ -73,13 +74,20 @@ class _Visitor extends SimpleAstVisitor<void> {

@override
void visitClassDeclaration(ClassDeclaration node) {
_check(node.members);
}

@override
void visitEnumDeclaration(EnumDeclaration node) {
_check(node.members);
}

void _check(NodeList<ClassMember> members) {
var getters = <String, MethodDeclaration>{};
var setters = <String, MethodDeclaration>{};

// Build getter/setter maps
var members = node.members.where(isMethod);

for (var member in members) {
for (var member in members.where(isMethod)) {
var method = member as MethodDeclaration;
if (method.isGetter) {
getters[method.name.toString()] = method;
Expand Down
2 changes: 2 additions & 0 deletions test/rules/all.dart
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ import 'tighten_type_of_initializing_formals.dart'
as tighten_type_of_initializing_formals;
import 'type_init_formals.dart' as type_init_formals;
import 'unawaited_futures.dart' as unawaited_futures;
import 'unnecessary_getters_setters.dart' as unnecessary_getters_setters;
import 'unnecessary_null_checks.dart' as unnecessary_null_checks;
import 'unnecessary_overrides.dart' as unnecessary_overrides;
import 'use_is_even_rather_than_modulo.dart' as use_is_even_rather_than_modulo;
Expand Down Expand Up @@ -82,6 +83,7 @@ void main() {
tighten_type_of_initializing_formals.main();
type_init_formals.main();
unawaited_futures.main();
unnecessary_getters_setters.main();
unnecessary_null_checks.main();
unnecessary_overrides.main();
use_is_even_rather_than_modulo.main();
Expand Down
40 changes: 40 additions & 0 deletions test/rules/unnecessary_getters_setters.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'package:test_reflective_loader/test_reflective_loader.dart';

import '../rule_test_support.dart';

main() {
defineReflectiveSuite(() {
defineReflectiveTests(UnnecessaryGettersSettersTest);
});
}

@reflectiveTest
class UnnecessaryGettersSettersTest extends LintRuleTest {
@override
List<String> get experiments => [
EnableString.enhanced_enums,
];

@override
String get lintRule => 'unnecessary_getters_setters';

@FailingTest(issue: 'https://github.com/dart-lang/linter/issues/3200')
test_enum() async {
await assertDiagnostics(r'''
enum A {
a,b,c;
var _contents;
get contents => _contents;
set contents(value) {
_contents = value;
}
}
''', [
lint('unnecessary_getters_setters', 41, 8),
]);
}
}