Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

enhanced enum tests for avoid_renaming_method_parameters #3188

Merged
merged 3 commits into from
Jan 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/rules/all.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import 'avoid_function_literals_in_foreach_calls.dart'
import 'avoid_init_to_null.dart' as avoid_init_to_null;
import 'avoid_redundant_argument_values.dart'
as avoid_redundant_argument_values;
import 'avoid_renaming_method_parameters.dart'
as avoid_renaming_method_parameters;
import 'avoid_returning_this.dart' as avoid_returning_this;
import 'avoid_shadowing_type_parameters.dart'
as avoid_shadowing_type_parameters;
Expand Down Expand Up @@ -56,6 +58,7 @@ void main() {
avoid_function_literals_in_foreach_calls.main();
avoid_init_to_null.main();
avoid_redundant_argument_values.main();
avoid_renaming_method_parameters.main();
avoid_returning_this.main();
avoid_shadowing_type_parameters.main();
avoid_types_as_parameter_names.main();
Expand Down
40 changes: 40 additions & 0 deletions test/rules/avoid_renaming_method_parameters.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'package:test_reflective_loader/test_reflective_loader.dart';

import '../rule_test_support.dart';

main() {
defineReflectiveSuite(() {
defineReflectiveTests(AvoidRenamingMethodParametersTest);
});
}

@reflectiveTest
class AvoidRenamingMethodParametersTest extends LintRuleTest {
@override
List<String> get experiments => [
EnableString.enhanced_enums,
];

@override
String get lintRule => 'avoid_renaming_method_parameters';

@FailingTest(issue: 'https://github.com/dart-lang/linter/issues/3095')
test_rename() async {
await assertDiagnostics(r'''
class C {
int f(int f) => f;
}
enum A implements C {
a,b,c;
@override
int f(int x) => x;
}
''', [
lint('avoid_renaming_method_parameters', 28, 8), // todo(pq): update index
]);
}
}