Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

enhanced enums tests for unnecessary_overrides #3187

Merged
merged 2 commits into from
Jan 27, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/rules/all.dart
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ import 'tighten_type_of_initializing_formals.dart'
import 'type_init_formals.dart' as type_init_formals;
import 'unawaited_futures.dart' as unawaited_futures;
import 'unnecessary_null_checks.dart' as unnecessary_null_checks;
import 'unnecessary_overrides.dart' as unnecessary_overrides;
import 'use_is_even_rather_than_modulo.dart' as use_is_even_rather_than_modulo;
import 'void_checks.dart' as void_checks;

Expand Down Expand Up @@ -78,6 +79,7 @@ void main() {
type_init_formals.main();
unawaited_futures.main();
unnecessary_null_checks.main();
unnecessary_overrides.main();
use_is_even_rather_than_modulo.main();
void_checks.main();
}
50 changes: 50 additions & 0 deletions test/rules/unnecessary_overrides.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'package:test_reflective_loader/test_reflective_loader.dart';

import '../rule_test_support.dart';

main() {
defineReflectiveSuite(() {
defineReflectiveTests(UnnecessaryOverridesTest);
});
}

@reflectiveTest
class UnnecessaryOverridesTest extends LintRuleTest {
@override
List<String> get experiments => [
EnableString.enhanced_enums,
];

@override
String get lintRule => 'unnecessary_overrides';

@FailingTest(issue: 'https://github.com/dart-lang/linter/issues/3097')
test_field() async {
await assertDiagnostics(r'''
enum A {
a,b,c;
@override
int get foo => 0;
}
''', [
lint('unnecessary_overrides', 28, 8),
]);
}

@FailingTest(issue: 'https://github.com/dart-lang/linter/issues/3097')
test_method() async {
await assertDiagnostics(r'''
enum A {
a,b,c;
@override
String bar() => '';
}
''', [
lint('unnecessary_overrides', 27, 8),
]);
}
}