Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create adjustable test settings. #152

Merged
merged 64 commits into from
Oct 21, 2023
Merged

Create adjustable test settings. #152

merged 64 commits into from
Oct 21, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Oct 10, 2023 •
edited
Loading

Contributes to flutter/flutter#135856

Draft of PR for Flutter to consume the changes: flutter/flutter#136692.

After merging this PR, I will update flutter/test, to have 8% of tests that are not leak free yet looking like this:

    testWidgets('initialTimerDuration falls within limit',
    experimentalLeakTracking: LeakTrackingForTests.ignored(),
    (WidgetTester tester) async {
        ...

@polina-c polina-c requested a review from CoderDake as a code owner October 10, 2023 16:04
@polina-c polina-c marked this pull request as draft October 10, 2023 16:04
@polina-c polina-c marked this pull request as ready for review October 13, 2023 02:23
kenzieschmoll
kenzieschmoll reviewed Oct 13, 2023
View reviewed changes
Copy link

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments around naming that might make these classes / method names more intuitive.

pkgs/leak_tracker/lib/src/leak_tracking/_primitives/model.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
goderbauer
goderbauer reviewed Oct 20, 2023
View reviewed changes
pkgs/leak_tracker/CHANGELOG.md Outdated Show resolved Hide resolved
pkgs/leak_tracker/lib/src/leak_tracking/_primitives/model.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker/lib/src/leak_tracking/_primitives/model.dart Show resolved Hide resolved
pkgs/leak_tracker/lib/src/leak_tracking/_primitives/model.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/lib/src/leak_tracking_for_tests.dart Outdated
void _emptyLeakHandler(Leaks leaks) {}

/// Leak tracking settings and helper methods for tests.
abstract class LeakTrackingForTests {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like LeakTrackingForTestsSettings and LeakTrackingForTests should just be one class then? Why do the statics need to be separated out?

@polina-c polina-c requested a review from goderbauer October 20, 2023 23:02
goderbauer
goderbauer approved these changes Oct 21, 2023
View reviewed changes
Copy link

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkgs/leak_tracker_flutter_testing/lib/src/leak_testing.dart Outdated Show resolved Hide resolved
pkgs/leak_tracker_flutter_testing/test/tests/leak_tracking_for_tests_test.dart Outdated Show resolved Hide resolved
@polina-c polina-c merged commit 1f2264e into dart-lang:main Oct 21, 2023
2 checks passed
@polina-c polina-c deleted the test-settings branch October 21, 2023 04:03
@polina-c polina-c mentioned this pull request Oct 23, 2023
Closed
24 tasks
@ValentinVignal ValentinVignal mentioned this pull request Nov 14, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@goderbauer goderbauer goderbauer approved these changes

@CoderDake CoderDake Awaiting requested review from CoderDake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polina-c @goderbauer @kenzieschmoll