Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using ObjectRecord instead of identityHashCode to identify objects. #146

Merged
merged 29 commits into from
Sep 20, 2023
Merged

Start using ObjectRecord instead of identityHashCode to identify objects. #146

merged 29 commits into from
Sep 20, 2023

Conversation

polina-c
Copy link
Contributor

No description provided.

polina-c added 28 commits August 27, 2023 15:19
@polina-c
-
7677cb1
@polina-c
-
9438a91
@polina-c
Update _retaining_path.dart
3ea8aae
@polina-c
-
510ebb7
@polina-c
-
4a7d271
@polina-c
Merge branch 'main' of github.com:dart-lang/leak_tracker into obj_id_…
b89c03d 
…for_ret_path
@polina-c
Update retaining_path_test.dart
6f852f7
@polina-c
-
06dea9a
@polina-c
Create helpers_test.dart
e264bb7
@polina-c
Update helpers_test.dart
5ef24bd
@polina-c
-
452f100
@polina-c
-
fe5a7cd
@polina-c
Update _object_records.dart
85e73c1
@polina-c
Update _object_record.dart
1e487bb
@polina-c
-
b58b63c
@polina-c
-
f030258
@polina-c
Update _object_records.dart
a08fc80
@polina-c
Update _object_records.dart
fc429b1
@polina-c
-
b3c381f
@polina-c
-
db261b3
@polina-c
-
8268041
@polina-c
Update _object_tracker_test.dart
a1a6fec
@polina-c
Merge branch 'main' of github.com:dart-lang/leak_tracker into obj_id_1
7006438
@polina-c
Update _object_tracker_test.dart
cf55ac1
@polina-c
Update _object_tracker_test.dart
427bfa8
@polina-c
Update _object_tracker_test.dart
4e25934
@polina-c
-
87309b6
@polina-c
Update _leak_filter_test.dart
6c681c4
@polina-c polina-c changed the title Start using weak references instead of identityHashCode to identify objects. Start using ObjectRecord instead of identityHashCode to identify objects. Sep 20, 2023
@polina-c polina-c marked this pull request as ready for review September 20, 2023 16:49
@polina-c polina-c requested a review from CoderDake as a code owner September 20, 2023 16:49
@polina-c polina-c requested a review from derekxu16 September 20, 2023 16:49
derekxu16
derekxu16 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@derekxu16 derekxu16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after my one comment is addressed.

@auto-submit auto-submit bot merged commit 455ba6c into dart-lang:main Sep 20, 2023
2 checks passed
@polina-c polina-c deleted the obj_id_1 branch September 20, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekxu16 derekxu16 derekxu16 approved these changes

@CoderDake CoderDake Awaiting requested review from CoderDake

Assignees
No one assigned
Labels
autosubmit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polina-c @derekxu16