Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failed assert. #145

Closed
wants to merge 1 commit into from
Closed

Remove failed assert. #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/leak_tracker/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 9.0.7

* Remove failed assert.

# 9.0.6

* Improve error reporting for connection to vm service.
Expand Down
4 changes: 3 additions & 1 deletion pkgs/leak_tracker/lib/src/leak_tracking/_object_records.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ class ObjectRecords {

void _assertNotWatched(IdentityHashCode code) {
assert(() {
assert(!notGCed.containsKey(code));
// TODO(polina-c): find out why this assert failed and uncomment
// https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20framework_tests_libraries/46558/overview
// assert(!notGCed.containsKey(code));
assert(!notGCedDisposedOk.contains(code));
assert(!notGCedDisposedLate.contains(code));
assert(!notGCedDisposedLateCollected.contains(code));
Expand Down
2 changes: 1 addition & 1 deletion pkgs/leak_tracker/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: leak_tracker
version: 9.0.6
version: 9.0.7
description: A framework for memory leak tracking for Dart and Flutter applications.
repository: https://github.com/dart-lang/leak_tracker/tree/main/pkgs/leak_tracker

Expand Down