Address a bunch of records issues. #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw #2413, so I'll take a look at that and see if that makes more sense that my rudimentary const support in this PR. |
rakudrama
reviewed
Aug 20, 2022
# Conflicts: # working/0546-patterns/records-feature-specification.md
There should be no meaningful changes. I just: - Fixed some misspellings. - Used Markdown style consistent with the rest of the doc. - Re-worded things to, I hope, read a little more naturally. - Removed the parenthetical on identical() in a const context because that felt a little too academic.
Specify the evaluation order of fields.
|
I'm going to go ahead and land this because it has changes that the implementation teams will want to take into account. Please don't hesitate to file issues if there are pieces of this you don't agree with. I'm trying to land and iterate in order to make progress. :) |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 6, 2022
This change is needed as a consequence of dart-lang/language#2422 where `()` was introduced as the syntax for the empty record as well as the empty record type. Change-Id: Ia8b3f590361343ca14355043c5898e7bd084c04e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261645 Reviewed-by: William Hesse <[email protected]> Auto-Submit: Erik Ernst <[email protected]> Commit-Queue: William Hesse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toString(). Fix What doestoStringon a record do? #2389.onclauses. Fix Record types and try-catch-on #2406.cc @eernstg @stereotype441 @jakemac53 @natebosch @kallentu @mit-mit