Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the dependency on package:web #931

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

devoncarew
Copy link
Member

  • remove the dependency on package:web

This removes the dep on package:web by in-lining the pieces we use. This is built on top of #928 - I'd review and land that first; I can update this after.

And - while this analyzes correctly and the tests run - I have not tried running this in a browser. We'd probably want to do that before a publish.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:intl 0.20.2 ready to publish intl-v0.20.2
package:intl4x 0.10.1 already published at pub.dev
package:intl_translation 0.20.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl Non-Breaking 0.20.1 0.20.2 0.20.2 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/intl/lib/date_symbol_data_http_request.dart 💔 Not covered
pkgs/intl/lib/intl_browser.dart 💚 100 %
pkgs/intl/lib/intl_standalone.dart 💚 75 %
pkgs/intl/lib/message_format.dart 💚 97 %
pkgs/intl/lib/src/file_data_reader.dart 💚 100 %
pkgs/intl/lib/src/http_request_data_reader.dart 💔 Not covered
pkgs/intl/lib/src/intl/number_format_parser.dart 💚 93 %
pkgs/intl/lib/src/lazy_locale_data.dart 💚 78 %
pkgs/intl/lib/src/web.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
intl StringStack
DateBuilder

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant