Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECMA PluralRules to package:intl4x #720

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Add ECMA PluralRules to package:intl4x #720

merged 3 commits into from
Sep 12, 2023

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Sep 11, 2023

Add support for Plural Rules.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:intl4x 0.7.0 ready to publish intl4x-v0.7.0
package:intl 0.19.0-dev pre-release version (no publish necessary)
package:intl_translation 0.19.0-dev pre-release version (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem marked this pull request as ready for review September 11, 2023 13:08
@mosuem mosuem requested a review from devoncarew September 11, 2023 13:08
@github-actions
Copy link

PR Health

Package publish validation ✔️

Details
Package Version Status
package:intl4x 0.7.0 ready to publish
package:intl 0.19.0-dev pre-release version (no publish necessary)
package:intl_translation 0.19.0-dev pre-release version (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/intl_translation/test/two_components/app_messages_all.dart
pkgs/intl_translation/test/two_components/app_messages_all_locales.dart
pkgs/intl_translation/test/two_components/component_messages_fr_xyz123.dart
pkgs/intl_translation/test/two_components/app_messages_fr.dart
pkgs/intl_translation/test/two_components/component_messages_all_locales.dart
pkgs/intl_translation/test/two_components/component_messages_all.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_all_locales.dart
pkgs/intl_translation/test/generate_localized/code_map_messages_fr.dart
pkgs/intl_translation/example/lib/generated/messages_iw.dart
pkgs/intl_translation/example/lib/generated/messages_de.dart
pkgs/intl_translation/example/lib/generated/messages_all_locales.dart
pkgs/intl_translation/example/lib/generated/messages_en.dart
pkgs/intl_translation/example/lib/generated/messages_all.dart
pkgs/intl_translation/example/lib/generated/messages_de_CH.dart
pkgs/intl_translation/example/lib/generated/messages_es.dart

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/intl4x/lib/intl4x.dart 💚 100 %
pkgs/intl4x/lib/plural_rules.dart 💔 Not covered
pkgs/intl4x/lib/src/plural_rules/plural_rules.dart 💚 63 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_4x.dart 💚 20 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_ecma.dart 💚 65 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_impl.dart 💚 100 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_options.dart 💚 50 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_stub.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Sep 11, 2023
@mosuem mosuem merged commit d3462c5 into main Sep 12, 2023
@mosuem mosuem deleted the addPluralRules branch September 12, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl4x type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants