Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing cupertino_http tests #949

Merged
merged 12 commits into from
May 30, 2023

Conversation

brianquinlan
Copy link
Collaborator

@brianquinlan brianquinlan commented May 25, 2023

fixes #938 by:

  • Retrying the the tests if they fail
  • Executing a single test entry point. The reason that this helps is because each test execution has about a 75% of succeeding so running the 13 existing tests have a 0.75^13 = 2% change of succeeding.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

(note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback)

@brianquinlan brianquinlan marked this pull request as draft May 25, 2023 22:04
@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label May 25, 2023
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label May 25, 2023
@brianquinlan brianquinlan changed the title Create a single huge test. Fix the failing cupertino_http tests May 26, 2023
@brianquinlan brianquinlan requested a review from liamappelbe May 26, 2023 17:34
@brianquinlan brianquinlan marked this pull request as ready for review May 26, 2023 19:52
@brianquinlan brianquinlan merged commit 18a43a2 into dart-lang:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cupertino_http Issues related to package:cupertino_http type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cupertino_http tests are failing are head when run using github workflows
2 participants