Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web_socket: allow latest pkg:web #1269

Merged
merged 1 commit into from
Jul 16, 2024
Merged

web_socket: allow latest pkg:web #1269

merged 1 commit into from
Jul 16, 2024

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jul 16, 2024

No description provided.

@kevmoo kevmoo requested a review from brianquinlan July 16, 2024 02:10
@github-actions GitHub Actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:web_socket 0.1.6 ready to publish web_socket-v0.1.6
package:cronet_http 1.3.2 already published at pub.dev
package:cupertino_http 1.5.1 already published at pub.dev
package:http 1.2.2-wip WIP (no publish necessary)
package:http_profile 0.1.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

srujzs
srujzs approved these changes Jul 16, 2024
View reviewed changes
Copy link

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I presume you've tested 0.5.0 and 1.0.0?

@kevmoo
Copy link
Member Author

kevmoo commented Jul 16, 2024

Thanks! I presume you've tested 0.5.0 and 1.0.0?

image

Testing old SDKs does the trick!

@kevmoo kevmoo merged commit a6d9f72 into master Jul 16, 2024
28 checks passed
@kevmoo kevmoo deleted the web_socket_latest_web branch July 16, 2024 15:53
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 16, 2024
@devoncarew
[deps] rev dartdoc, http, web_socket_channel
82ffb7d 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/f6f93dd..1d00523):
  1d005239  2024-07-15  István Soós  Allow alert classnames in HTML sanitization. (dart-lang/dartdoc#3820)

http (https://github.com/dart-lang/http/compare/edbb5a9..757438e):
  757438e  2024-07-16  Kevin Moore  Bump pkg:web dependency (dart-lang/http#1272)
  a6d9f72  2024-07-16  Kevin Moore  web_socket: allow latest pkg:web (dart-lang/http#1269)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/8e95ea7..0e1d6e2):
  0e1d6e2  2024-07-16  Kevin Moore  Support latest pkg:web, prepare release (dart-lang/web_socket_channel#377)

Change-Id: I748eb0ac16e5dda2f0b84f44838ed01871b1f4c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376027
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Kevin Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

@brianquinlan brianquinlan Awaiting requested review from brianquinlan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @srujzs