Replace Objective-C implemented delegates with Dart implementations #1218

brianquinlan · 2024-05-30T23:10:17Z

Fixes #1298

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

github-actions · 2024-09-03T22:49:06Z

PR Health

Changelog Entry ❗

Package	Changed Files
package:http	pkgs/http/pubspec.yaml
package:web_socket	pkgs/web_socket/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage

⚠️

File	Coverage
pkgs/cupertino_http/example/integration_test/http_url_response_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/main.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/mutable_url_request_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_cache_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_request_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_response_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_configuration_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_delegate_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_task_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/url_session_test.dart	💔 Not covered
pkgs/cupertino_http/example/integration_test/utils_test.dart	💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_api.dart	💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_client.dart	💔 Not covered
pkgs/cupertino_http/lib/src/cupertino_web_socket.dart	💔 Not covered
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart	💔 Not covered
pkgs/cupertino_http/lib/src/utils.dart	💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

License Headers

⚠️

// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/cronet_http/lib/src/jni/jni_bindings.dart
pkgs/http/example/main.dart
pkgs/http2/test/src/flowcontrol/mocks.mocks.dart
pkgs/http_client_conformance_tests/example/client_test.dart
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart
pkgs/http_client_conformance_tests/lib/src/multipart_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/multipart_server_web.dart
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_web.dart
pkgs/http_client_conformance_tests/lib/src/redirect_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/redirect_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_headers_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_headers_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_methods_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_methods_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_headers_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_headers_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_web.dart
pkgs/http_client_conformance_tests/lib/src/server_errors_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/server_errors_server_web.dart
pkgs/http_parser/test/example_test.dart
pkgs/http_profile/lib/http_profile.dart
pkgs/java_http/lib/src/third_party/java/io/BufferedInputStream.dart
pkgs/java_http/lib/src/third_party/java/io/InputStream.dart
pkgs/java_http/lib/src/third_party/java/io/OutputStream.dart
pkgs/java_http/lib/src/third_party/java/io/_package.dart
pkgs/java_http/lib/src/third_party/java/lang/System.dart
pkgs/java_http/lib/src/third_party/java/lang/_package.dart
pkgs/java_http/lib/src/third_party/java/net/HttpURLConnection.dart
pkgs/java_http/lib/src/third_party/java/net/URL.dart
pkgs/java_http/lib/src/third_party/java/net/URLConnection.dart
pkgs/java_http/lib/src/third_party/java/net/_package.dart
pkgs/ok_http/lib/src/jni/bindings.dart
pkgs/web_socket/example/web_socket_example.dart
pkgs/web_socket/lib/testing.dart
pkgs/web_socket_conformance_tests/example/client_test.dart
pkgs/web_socket_conformance_tests/lib/src/close_local_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/close_local_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/echo_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/echo_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/protocol_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/protocol_server_web.dart

This check can be disabled by tagging the PR with skip-license-check.

liamappelbe

So much deleted code! LGTM

liamappelbe · 2024-10-23T02:00:26Z

pkgs/cupertino_http/lib/src/cupertino_api.dart

+        }
+      });
+
+      final downloadDelegate = objc.getProtocol('NSURLSessionDownloadDelegate');


I've filed dart-lang/native#1675 so you won't have to do this in future.

mosuem · 2024-10-23T06:23:36Z

pkgs/cupertino_http/pubspec.yaml

@@ -4,10 +4,11 @@ description: >-
  A macOS/iOS Flutter plugin that provides access to the Foundation URL
  Loading System.
 repository: https://github.com/dart-lang/http/tree/master/pkgs/cupertino_http
+publish_to: no


Suggested change

publish_to: no

publish_to: none

The publish_to directive was there by accident.

github-actions · 2024-10-23T15:52:24Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:http2	2.3.1	ready to publish	`http2-v2.3.1`
package:cronet_http	1.3.3-wip	WIP (no publish necessary)
package:http	1.2.3-wip	WIP (no publish necessary)
package:http_parser	4.1.1	already published at pub.dev
package:http_profile	0.1.1-wip	WIP (no publish necessary)
package:ok_http	0.1.1-wip	WIP (no publish necessary)
package:web_socket	0.1.6	already published at pub.dev
package:cupertino_http	1.5.2-wip	(error) pubspec version (1.5.2-wip) and changelog (2.0.0-wip) don't agree

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

…ecosystem, fixnum, http, lints, logging, markdown, path, sync_http, test, typed_data, vector_math, web Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/5f70a99..d6a6a4d): d6a6a4d 2024-10-17 Moritz Update README.md before archiving (dart-archive/async#287) clock (https://github.com/dart-lang/clock/compare/7956d60..8dfee80): 8dfee80 2024-10-28 Moritz Update README.md (dart-archive/clock#70) collection (https://github.com/dart-lang/collection/compare/887b826..96afcc2): 96afcc2 2024-10-21 Moritz Update README.md before archiving (dart-archive/collection#362) convert (https://github.com/dart-lang/convert/compare/d361833..836082a): 836082a 2024-10-17 Moritz Update README.md before archiving (dart-archive/convert#110) core (https://github.com/dart-lang/core/compare/2a436d5..9ad6888): 9ad68884 2024-10-25 Kevin Moore os_detect: bump lints and SDK versions (dart-lang/core#713) crypto (https://github.com/dart-lang/crypto/compare/3d26ef4..255edfb): 255edfb 2024-10-17 Moritz Update README.md before archiving (dart-archive/crypto#184) dartdoc (https://github.com/dart-lang/dartdoc/compare/73344a2..5168f81): 5168f81a 2024-10-27 Parker Lougheed Remove unnecessary and unused styles (dart-lang/dartdoc#3918) d4876f94 2024-10-25 Parker Lougheed Compress generated css by configuring sass output style (dart-lang/dartdoc#3919) d83146fa 2024-10-25 Parker Lougheed Generate included css using sass (dart-lang/dartdoc#3917) 4d461298 2024-10-24 Parker Lougheed Update to Dart 3.5 and web 1.1 (dart-lang/dartdoc#3915) ecosystem (https://github.com/dart-lang/ecosystem/compare/2d58550..66ddc4f): 66ddc4f 2024-10-28 Devon Carew refactor the CI to use per-package workflow config files (dart-lang/ecosystem#312) 673428a 2024-10-24 Devon Carew ignore redundant 'type-' labels (dart-lang/ecosystem#309) d5c8c18 2024-10-15 Devon Carew remove the 'version' section from the health checks (dart-lang/ecosystem#305) fixnum (https://github.com/dart-lang/fixnum/compare/83293b8..8543972): 8543972 2024-10-17 Moritz Update README.md before archiving (dart-archive/fixnum#134) http (https://github.com/dart-lang/http/compare/5e2281e..f5ec11c): f5ec11c 2024-10-25 dependabot[bot] Bump the github-actions group across 1 directory with 5 updates (dart-lang/http#1392) bd8eb4b 2024-10-24 Brian Quinlan Remove package:java_http (dart-lang/http#1389) d921e48 2024-10-23 Brian Quinlan Replace Objective-C implemented delegates with Dart implementations (dart-lang/http#1218) lints (https://github.com/dart-lang/lints/compare/5016d63..19d99bc): 19d99bc 2024-10-21 Moritz Update README.md before archiving (dart-lang/lints#214) logging (https://github.com/dart-lang/logging/compare/6fa0560..a41a508): a41a508 2024-10-18 Moritz Update README.md (dart-archive/logging#175) markdown (https://github.com/dart-lang/markdown/compare/d53feae..207bb44): 207bb44 2024-10-16 andrechalella Update pub run syntax and remove 404 images (dart-lang/markdown#625) 62153ee 2024-10-16 andrechalella Fix `RangeError` hazards in links (dart-lang/markdown#624) path (https://github.com/dart-lang/path/compare/e969f42..7e3d5d8): 7e3d5d8 2024-10-17 Moritz Update README.md (dart-archive/path#172) sync_http (https://github.com/dart-lang/sync_http/compare/91c0dd5..44b5913): 44b5913 2024-10-28 Devon Carew Update analysis_options.yaml (google/sync_http.dart#51) df54f0d 2024-10-28 dependabot[bot] Bump actions/checkout from 4.1.7 to 4.2.0 (google/sync_http.dart#50) test (https://github.com/dart-lang/test/compare/73e30fb..fe38650): fe386504 2024-10-22 Nate Bosch Remove deprecated lint package_api_docs (dart-lang/test#2411) typed_data (https://github.com/dart-lang/typed_data/compare/6abfafd..b269d39): b269d39 2024-10-18 Moritz Update README.md before archiving (dart-archive/typed_data#94) vector_math (https://github.com/google/vector_math.dart/compare/2cfbe2c..da9889f): da9889f 2024-10-16 dependabot[bot] Bump the github-actions group across 1 directory with 2 updates (google/vector_math.dart#332) 33d5ecb 2024-10-15 Devon Carew Update dependabot.yaml (google/vector_math.dart#331) web (https://github.com/dart-lang/web/compare/8478cd2..d3a61aa): d3a61aa 2024-10-12 Parker Lougheed Remove deprecated package_api_docs lint (dart-lang/web#315) Change-Id: I465d31409f68a0d6f10a60ffb9cfd505957f79e0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392200 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>

brianquinlan added 3 commits May 29, 2024 18:31

Protocol work

dcd2997

More fixes

e993fc0

More fixes

951385a

brianquinlan marked this pull request as draft May 30, 2024 23:10

github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label May 30, 2024

brianquinlan added 10 commits June 4, 2024 14:34

Compiles (except for bindings)

2ccf126

Fix error string

334386e

More

89a7617

All tests passing

13dab90

Delegate

bf94f4e

Regen

9527dd4

Compiling

419de5a

Fixes

1f97822

Merge remote-tracking branch 'upstream/master' into dart_protocol

cd6ff95

Merge

a325f08

brianquinlan added 14 commits September 10, 2024 17:17

Protocol

aa0ebc6

Working conformance

0c485c2

Works on iOS

715d3fe

Track task count

8569676

Fix

7f6608d

WebSockets work!

868b929

Remove useless utils

5d0beb3

Remove source

acbb822

Update .gitattributes

0b14c14

Remove DS_Store

2137584

Remove

e256587

Update http_url_response_test.dart

6e1c66f

Tests compile but don't pass

6541724

Fix

3b4c6a4

brianquinlan added 11 commits October 21, 2024 15:25

Update pubspec.yaml

8f7000c

Merge remote-tracking branch 'upstream/master' into dart_protocol

2d1e7d6

Update pubspec.yaml

9da1312

Monorepo

aa4eca7

Test

cace60f

Update pubspec.yaml

4731092

test

e9ed9c6

Test

98be9b1

Update dart.yml

0ccae2f

More CI fixes

bdfd356

Bump http version

2dde428

github-actions bot added the package:http label Oct 21, 2024

brianquinlan added 7 commits October 21, 2024 17:01

Fix

f081949

Test, revert!

5d378c1

Protocol fix.

770498a

Ignore some files

2d32e68

Update health.yaml

26d7753

Fix

0bbc612

Update cronet.yml

2465c2d

brianquinlan marked this pull request as ready for review October 22, 2024 18:11

brianquinlan added 3 commits October 22, 2024 11:13

Update utils.h

57db225

No fail-fast

3394fb0

Version

99d8d3c

liamappelbe approved these changes Oct 23, 2024

View reviewed changes

mosuem reviewed Oct 23, 2024

View reviewed changes

Update pubspec.yaml

e14f6e2

brianquinlan merged commit d921e48 into dart-lang:master Oct 23, 2024
33 of 38 checks passed

brianquinlan deleted the dart_protocol branch October 23, 2024 17:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Objective-C implemented delegates with Dart implementations #1218

Replace Objective-C implemented delegates with Dart implementations #1218

brianquinlan commented May 30, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

liamappelbe left a comment

liamappelbe Oct 23, 2024

mosuem Oct 23, 2024

brianquinlan Oct 23, 2024

github-actions bot commented Oct 23, 2024

Replace Objective-C implemented delegates with Dart implementations #1218

Replace Objective-C implemented delegates with Dart implementations #1218

Conversation

brianquinlan commented May 30, 2024 • edited Loading

github-actions bot commented Sep 3, 2024 • edited Loading

PR Health

liamappelbe left a comment

Choose a reason for hiding this comment

liamappelbe Oct 23, 2024

Choose a reason for hiding this comment

mosuem Oct 23, 2024

Choose a reason for hiding this comment

brianquinlan Oct 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 23, 2024

Package publishing

brianquinlan commented May 30, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading