Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 1000 as a WebSocket close code #1211

Merged
merged 1 commit into from
May 24, 2024

Conversation

brianquinlan
Copy link
Collaborator

Fixes #1203


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label May 23, 2024
@brianquinlan brianquinlan requested a review from natebosch May 23, 2024 23:27
@brianquinlan brianquinlan merged commit 0937562 into dart-lang:master May 24, 2024
30 checks passed
@catapop84
Copy link

Hello, You should allow a range between 1000-4999 according to official doc: https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent/code and https://www.rfc-editor.org/rfc/rfc6455.html#section-7.1.5

@brianquinlan brianquinlan deleted the 1000_close_code branch May 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cupertino_http Issues related to package:cupertino_http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing WebSocket throws error if code is not in range 3000 - 4999
3 participants