Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WebSocketConnectionClosed for operations after WebSocket close #1180

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Use WebSocketConnectionClosed for operations after WebSocket close #1180

merged 3 commits into from
Apr 25, 2024

Conversation

brianquinlan
Copy link
Collaborator

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Apr 23, 2024
@brianquinlan brianquinlan requested a review from natebosch April 24, 2024 00:04
@brianquinlan brianquinlan merged commit e459e5c into dart-lang:master Apr 25, 2024
30 checks passed
@brianquinlan brianquinlan deleted the wrong_exception branch April 25, 2024 21:56
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 29, 2024
@devoncarew
[deps] rev http, web_socket_channel
9f73756 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

http (https://github.com/dart-lang/http/compare/34d7087..e459e5c):
  e459e5c  2024-04-25  Brian Quinlan  Use WebSocketConnectionClosed for operations after WebSocket close (dart-lang/http#1180)
  9780081  2024-04-25  Brian Quinlan  Make the cupertino_http workflow work after 'macos-latest' upgrade (dart-lang/http#1182)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/b612fc2..b672220):
  b672220  2024-04-26  Brian Quinlan  Fix a race when close() called before remote class event delivered (dart-archive/web_socket_channel#348)

Change-Id: Ib8946161d9a2c626339901d4de03e989e81159d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364820
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
package:cupertino_http Issues related to package:cupertino_http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianquinlan @natebosch