Fix a bug where cronet_http sends incorrect HTTP request methods #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2023
AlexV525
reviewed
Nov 29, 2023
|
|
||
| test('custom method', () async { | ||
| await client.send(Request( | ||
| 'CUSTOM', |
There was a problem hiding this comment.
Should we test case-sensitive method too?
There was a problem hiding this comment.
The problem is that IOClient would not pass that test because it always uppercases the request method:
https://github.com/dart-lang/sdk/blob/0b10bfcde99def6c43d4a306c920ba1ba855d058/sdk/lib/_http/http_impl.dart#L2791
This seems like a bug according to RFC-7232: https://www.rfc-editor.org/rfc/rfc7231#section-4.1
I will add a case-insensitive test and then a flag to disable it.
There was a problem hiding this comment.
Oh well, another bug, good spot. 👍
brianquinlan
requested review from
devoncarew
and removed request for
natebosch
devoncarew
approved these changes
Nov 29, 2023
|
@brianquinlan Could you also publish a new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package:cronet_httpwas always sending the "GET" HTTP request method, even for methods likeclient.postCronetClientdidn't setup proper method for requests #1053Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.