-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use efficient operations when copying bytes between Dart and Java #1019
Conversation
Not directly related to this PR:
|
Done.
Done. |
DBC: Could you post some ball-park perf improvements here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @brianquinlan!
Done in the commit message. |
Sweet! |
@brianquinlan what Dart/Flutter version was this? cc @sstrickl our downstream users benefitting from your recent stack of improvements to |
3.1.0 - I updated the commit message |
package:jni
0.7.0 to copy bytes between Dart and Java.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.