New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the cronet callbacks from the `send` method #1017

Merged

brianquinlan merged 1 commit into dart-lang:master from brianquinlan:client_shorter

Sep 12, 2023

Collaborator

brianquinlan commented Sep 12, 2023

Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Separate the cronet callbacks from the send method

github-actions bot added the package:cronet_http label

brianquinlan requested a review from natebosch

September 12, 2023 23:09

brianquinlan assigned natebosch

natebosch approved these changes

View reviewed changes

brianquinlan merged commit eafbbb0 into dart-lang:master

15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:cronet_http