remove the 'version' section from the health checks

.github/workflows/health.yaml

@@ -21,8 +21,8 @@ name: Health
 #     uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
 #     with:
 #       sdk: beta
-#       checks: "version,changelog,license,coverage,breaking,do-not-submit,leaking"
-#       fail_on: "version,changelog,do-not-submit"
+#       checks: "changelog,license,coverage,breaking,do-not-submit,leaking"
+#       fail_on: "changelog,do-not-submit"
 #       warn_on: "license,coverage,breaking,leaking"
 #       coverage_web: false
 #       upload_coverage: false
@@ -52,17 +52,17 @@ on:
       # Restrict the checks to any subset of version, changelog, and license if
       # needed.
       checks:
-        description: What to check for in the PR health check - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
-        default: "version,changelog,license,coverage,breaking,do-not-submit,leaking"
+        description: What to check for in the PR health check - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
+        default: "changelog,license,coverage,breaking,do-not-submit,leaking"
         type: string
         required: false
       fail_on:
-        description: Which checks should lead to failure - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
-        default: "version,changelog,do-not-submit"
+        description: Which checks should lead to failure - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
+        default: "changelog,do-not-submit"
         type: string
         required: false
       warn_on:
-        description: Which checks should not fail, but only warn - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
+        description: Which checks should not fail, but only warn - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
         default: "license,coverage,breaking,leaking"
         type: string
         required: false
@@ -113,19 +113,6 @@ on:
         required: false
 
 jobs:
-  version:
-    if: ${{ contains(inputs.checks, 'version') }}
-    uses: ./.github/workflows/health_base.yaml
-    with:
-      sdk: ${{ inputs.sdk }}
-      check: version
-      fail_on: ${{ inputs.fail_on }}
-      warn_on: ${{ inputs.warn_on }}
-      local_debug: ${{ inputs.local_debug }}
-      use-flutter: ${{ inputs.use-flutter }}
-      ignore_packages: ${{ inputs.ignore_packages }}
-      checkout_submodules: ${{ inputs.checkout_submodules }}
-
   changelog:
     if: ${{ contains(inputs.checks, 'changelog') }}
     uses: ./.github/workflows/health_base.yaml
@@ -210,7 +197,7 @@ jobs:
       checkout_submodules: ${{ inputs.checkout_submodules }}
 
   comment:
-    needs: [version, changelog, license, coverage, breaking, do-not-submit, leaking]
+    needs: [changelog, license, coverage, breaking, do-not-submit, leaking]
     if: always()
     # These permissions are required for us to create comments on PRs.
     permissions:

.github/workflows/health_base.yaml

@@ -16,16 +16,16 @@ on:
         required: false
         type: string
       check:
-        description: What to check for in the PR health check - any of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
+        description: What to check for in the PR health check - any of "changelog,license,coverage,breaking,do-not-submit,leaking"
         type: string
         required: true
       fail_on:
-        description: Which checks should lead to failure - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
-        default: "version,changelog,do-not-submit"
+        description: Which checks should lead to failure - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
+        default: "changelog,do-not-submit"
         type: string
         required: false
       warn_on:
-        description: Which checks should not fail, but only warn - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
+        description: Which checks should not fail, but only warn - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
         default: "license,coverage,breaking,leaking"
         type: string
         required: false

.github/workflows/health_internal.yaml

@@ -12,8 +12,8 @@ jobs:
       local_debug: true
       coverage_web: false
       upload_coverage: false
-      checks: version,changelog,license,coverage,breaking,do-not-submit,leaking
-      fail_on: version,changelog,do-not-submit
+      checks: changelog,license,coverage,breaking,do-not-submit,leaking
+      fail_on: changelog,do-not-submit
       warn_on: license,coverage,breaking,leaking
       ignore_license: 'pkgs/firehose/test_data'
       ignore_coverage: 'pkgs/firehose/bin,pkgs/firehose/test_data'

pkgs/firehose/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.10.0
+
+- Remove the `version` pubspec checks (these largely duplicate the feedback
+  provided by publishing automation).
+
 ## 0.9.3
 
 - Do not check Dart SDK in PR Health breaking check.

pkgs/firehose/README.md

@@ -160,7 +160,6 @@ This is a Github workflow to check PR health.
 
 When run from a PR, this tool will check a configurable subset of the following
 
-* The package versioning is correct and consistent, see `firehose` description above.
 * A changelog entry has been added.
 * All `.dart` files have a license header.
 * How the test coverage is affected by the PR.
@@ -187,8 +186,8 @@ jobs:
     uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
 #   with:
 #     sdk: beta
-#     checks: "version,changelog,license,coverage,breaking,do-not-submit,leaking"
-#     fail_on: "version,changelog,do-not-submit"
+#     checks: "changelog,license,coverage,breaking,do-not-submit,leaking"
+#     fail_on: "changelog,do-not-submit"
 #     warn_on: "license,coverage,breaking,leaking"
 #     coverage_web: false
 #     upload_coverage: false
@@ -229,8 +228,8 @@ jobs:
 
 | Name | Type | Description | Example |
 | ------------- | ------------- | ------------- | ------------- |
-| checks  | List of strings  | What to check for in the PR health check | `"version,changelog,license,coverage,breaking,do-not-submit,leaking"` |
-| fail_on  | List of strings  | Which checks should lead to failure | `"version,changelog,do-not-submit"` |
+| checks  | List of strings  | What to check for in the PR health check | `"changelog,license,coverage,breaking,do-not-submit,leaking"` |
+| fail_on  | List of strings  | Which checks should lead to failure | `"changelog,do-not-submit"` |
 | warn_on  | List of strings  | Which checks should not fail, but only warn | `"license,coverage,breaking,leaking"` |
 | upload_coverage  | boolean  | Whether to upload the coverage to [coveralls](https://coveralls.io/) | `true` |
 | coverage_web  | boolean  | Whether to run `dart test -p chrome` for coverage | `false` |

pkgs/firehose/lib/src/health/health.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: always_declare_return_types
-
 import 'dart:convert';
 import 'dart:io';
 import 'dart:math';
@@ -20,7 +18,6 @@ import 'coverage.dart';
 import 'license.dart';
 
 enum Check {
-  version('Package publish validation', 'version'),
   license('License Headers', 'license'),
   changelog('Changelog Entry', 'changelog'),
   coverage('Coverage', 'coverage'),
@@ -119,7 +116,6 @@ class Health {
   }
 
   Future<HealthCheckResult> Function() checkFor(Check check) => switch (check) {
-        Check.version => validateCheck,
         Check.license => licenseCheck,
         Check.changelog => changelogCheck,
         Check.coverage => coverageCheck,
@@ -128,26 +124,6 @@ class Health {
         Check.leaking => leakingCheck,
       };
 
-  Future<HealthCheckResult> validateCheck() async {
-    //TODO: Add Flutter support for PR health checks
-    var results =
-        await Firehose(directory, false, ignoredPackages).verify(github);
-
-    var markdownTable = '''
-| Package | Version | Status |
-| :--- | ---: | :--- |
-${results.describeAsMarkdown(withTag: false)}
-
-Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
-    ''';
-
-    return HealthCheckResult(
-      Check.version,
-      results.severity,
-      markdownTable,
-    );
-  }
-
   Future<HealthCheckResult> breakingCheck() async {
     final filesInPR = await github.listFilesForPR(directory, ignoredPackages);
     final changeForPackage = <Package, BreakingChange>{};

pkgs/firehose/pubspec.yaml

@@ -1,6 +1,6 @@
 name: firehose
 description: A tool to automate publishing of Pub packages from GitHub actions.
-version: 0.9.3
+version: 0.10.0
 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose
 
 environment: