Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to health.yaml #201

Merged
merged 13 commits into from
Dec 1, 2023
Merged

Upgrades to health.yaml #201

merged 13 commits into from
Dec 1, 2023

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Nov 22, 2023

  • Continue health.yaml on error so that the message is written even on an error in the workflow.
  • Switch the backend to package:github.
  • Check for DO_NOT_SUBMIT in the PR description.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from devoncarew November 22, 2023 12:21
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

PR Health

Package publish validation ✔️

Details
Package Version Status
package:firehose 0.4.0 ready to publish
package:dart_flutter_team_lints 2.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/firehose/bin/firehose.dart 💔 Not covered
pkgs/firehose/lib/firehose.dart 💔 Not covered
pkgs/firehose/lib/src/github.dart 💚 72 % ⬆️ 516 %
pkgs/firehose/lib/src/health/changelog.dart 💔 Not covered
pkgs/firehose/lib/src/health/coverage.dart 💚 41 %
pkgs/firehose/lib/src/health/health.dart 💔 Not covered
pkgs/firehose/lib/src/repo.dart 💚 87 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 2.1.1 2.1.1 2.1.1 ✔️
firehose Breaking 0.3.33 0.4.0 0.4.0 ✔️

Copy link

github-actions bot commented Nov 22, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.4.0 ready to publish firehose-v0.4.0
package:dart_flutter_team_lints 2.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem changed the title Continue health.yaml on error Upgrades to health.yaml Nov 22, 2023
@mosuem mosuem merged commit 32461a7 into main Dec 1, 2023
@mosuem mosuem deleted the continueHealthOnError branch December 1, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants