Add api tool call for testing #153

mosuem · 2023-08-29T17:23:31Z

Check for breaking changes.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

github-actions · 2023-08-29T17:25:31Z

PR Health

Package publish validation ✔️

Details

Package	Version	Status
package:firehose	0.3.31	ready to publish
package:dart_flutter_team_lints	2.0.0	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details

// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details

File	Coverage
pkgs/firehose/bin/health.dart	💔 Not covered
pkgs/firehose/lib/src/health/health.dart	💔 Not covered
pkgs/firehose/lib/src/repo.dart	💚 87 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

Breaking changes ⚠️

Details

Package	Change	Current Version	New Version	Needed Version	Looking good?
firehose	Breaking	0.3.30	0.3.31	0.4.0	⚠️
dart_flutter_team_lints	None	2.0.0	2.0.0	2.0.0	✔️

This check can be disabled by tagging the PR with skip-breaking-check

.github/workflows/health_internal.yaml

pkgs/firehose/lib/src/health/health.dart

github-actions · 2023-09-27T14:43:36Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:firehose	0.3.31	ready to publish	`firehose-v0.3.31`
package:dart_flutter_team_lints	2.0.0	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

pkgs/firehose/lib/firehose.dart

devoncarew · 2023-09-28T04:34:37Z

pkgs/firehose/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.31


Just fyi there are a few PRs underway rev'ing firehose -

devoncarew · 2023-09-28T04:40:45Z

.github/workflows/health.yaml

@@ -92,6 +92,9 @@ jobs:
        run: dart pub global activate firehose
        if:  ${{ !inputs.local_debug }}

+      - name: Install api_tool
+        run: dart pub global activate --source git https://github.com/bmw-tech/dart_apitool


I take it that this tool isn't published to pub?

It is - the version I want is just not published yet.

devoncarew · 2023-09-28T04:43:28Z

pkgs/firehose/lib/src/health/health.dart

+      );
+      print('Look for changes in $currentPath with base $basePackage');
+      var runApiTool = Process.runSync(
+        'dart-apitool',


Perhaps instead 'dart, ['pub', 'global', 'run', 'dart-apitool', ...? It's the same as what you have, just doesn't rely on the pub tools dir being installed into the PATH ...

devoncarew · 2023-09-28T04:46:49Z

pkgs/firehose/lib/src/health/health.dart

+          'diff',
+          ...['--old', basePackage],
+          ...['--new', '.'],
+          ...['--report-format', 'json'],


If this run finds breaking changes, should we re-run this report in another format and dump the results to stdout?

This reverts commit ada4234.

Add api tool call for testing

b2d4ff7

github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Aug 29, 2023

mosuem added 13 commits August 29, 2023 19:32

Change tag

29cc8b6

Add debugging log

22fbb6c

look in each package

d14f30e

debug

c893a6f

take subpackage

54b00b7

Run in current

ed7c17c

add debug

597f95d

debug

1602049

Add argument for testing

d04f966

Switch to local copy

e6d2c5d

Add pub get to apitool clone

11c1093

move dart install

e694a6f

Revert changes

42f750d

mosuem mentioned this pull request Aug 31, 2023

Fix #148. bmw-tech/dart_apitool#149

Closed

7 tasks

mosuem added 4 commits September 11, 2023 09:49

Fix ref

5a30607

Merge branch 'main' into apitToolHealth

ea62622

dart fix

ab4cdb4

Switch to main branch

36aac52

mosuem commented Sep 12, 2023

View reviewed changes

.github/workflows/health_internal.yaml Outdated Show resolved Hide resolved

mosuem commented Sep 12, 2023

View reviewed changes

pkgs/firehose/lib/src/health/health.dart Outdated Show resolved Hide resolved

mosuem added 4 commits September 27, 2023 14:32

Merge branch 'main' into apitToolHealth

7c6d881

use new

2cbfdc8

use report file

459b25c

Add test argument

ada4234

mosuem force-pushed the apitToolHealth branch from 86a9189 to ada4234 Compare September 27, 2023 13:11

Organize imports

5542840

mosuem added 13 commits September 27, 2023 15:58

Nicer output

0ad660a

Fix version

510abf9

Really fix

dab1b08

fix path

6f8bdc4

Make nicer

078566c

Add severity

7fd83a7

Even nicer

bdf61fa

Fix layout

9ebdbab

Make bold

bf6746a

Capitalize

b88a2d1

Really bolden

f4e9682

Enable all checks

f0e944c

Rev version

26c1ba9

mosuem requested a review from devoncarew September 27, 2023 14:46

mosuem marked this pull request as ready for review September 27, 2023 14:47

Make nullsafer

ca1d300

mosuem commented Sep 27, 2023

View reviewed changes

pkgs/firehose/lib/firehose.dart Outdated Show resolved Hide resolved

mosuem added 2 commits September 27, 2023 16:52

add DO_NOT_SUBMIT

2538134

Remove empty file

14c9a94

devoncarew approved these changes Sep 28, 2023

View reviewed changes

mosuem added 3 commits September 28, 2023 12:55

Changes as per review

82c2a4f

Revert "Add test argument"

a2c044c

This reverts commit ada4234.

Fix call

8702ab8

mosuem merged commit bc2dd27 into main Sep 28, 2023
17 checks passed

mosuem deleted the apitToolHealth branch September 28, 2023 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add api tool call for testing #153

Add api tool call for testing #153

mosuem commented Aug 29, 2023 •

edited

Loading

github-actions bot commented Aug 29, 2023 •

edited

Loading

github-actions bot commented Sep 27, 2023

devoncarew Sep 28, 2023

devoncarew Sep 28, 2023

mosuem Sep 28, 2023

devoncarew Sep 28, 2023

devoncarew Sep 28, 2023

Add api tool call for testing #153

Add api tool call for testing #153

Conversation

mosuem commented Aug 29, 2023 • edited Loading

github-actions bot commented Aug 29, 2023 • edited Loading

PR Health

Package publish validation ✔️

License Headers ✔️

Changelog Entry ✔️

Coverage ⚠️

Breaking changes ⚠️

github-actions bot commented Sep 27, 2023

Package publishing

devoncarew Sep 28, 2023

Choose a reason for hiding this comment

devoncarew Sep 28, 2023

Choose a reason for hiding this comment

mosuem Sep 28, 2023

Choose a reason for hiding this comment

devoncarew Sep 28, 2023

Choose a reason for hiding this comment

devoncarew Sep 28, 2023

Choose a reason for hiding this comment

mosuem commented Aug 29, 2023 •

edited

Loading

github-actions bot commented Aug 29, 2023 •

edited

Loading