Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append the href of each library with a slash #3940

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Dec 3, 2024

Fixes #3936


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Copy link
Member Author

srawlins commented Dec 3, 2024

CC @isoos in case you'd like to test before I merge

CC @dart-lang/analyzer-team

@isoos
Copy link
Contributor

isoos commented Dec 3, 2024

This looks good to me, thank you!

@srawlins srawlins merged commit e3ecb4d into dart-lang:main Dec 4, 2024
7 checks passed
@srawlins srawlins deleted the slashes branch December 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The generated library URLs need an ending slash
3 participants