Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split existing CSS styles into multiple scss partials #3920

Merged
merged 4 commits into from
Nov 23, 2024

Conversation

parlough
Copy link
Member

This PR doesn't change the styles at all or start to take advantage of sass features for the styles themselves. It just splits the existing styles into multiple scss partials and includes them in the root web/styles/styles.scss file. This will help keep related styles together, as was already attempted with inline comments before some parts of the original file.

@parlough parlough marked this pull request as ready for review November 3, 2024 02:20
@parlough
Copy link
Member Author

@srawlins Any thoughts on this PR? Once this lands I'll start taking advantage of sass features and making some style fixes.

@parlough parlough requested a review from srawlins November 17, 2024 06:07
@srawlins
Copy link
Member

Hey @parlough sorry for the delay! I'm doing some other stuff until Thursday, so I should be able to give this a review, and manual testing, on Thursday!

@srawlins
Copy link
Member

It's funny because I think we really don't use too many styles; hard to check visually but everything looks fine to me. I launched the Dart SDK docs (dart tool/task.dart serve sdk) and everything looks good. Clicked around different types of pages.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the organization so much ❤️ .

After reading the code I realized that I hadn't looked at search or mobile / responsive UI. Both looks great!

@srawlins
Copy link
Member

The only thing that caught my eye was how method signatures look in dark mode:

Screenshot 2024-11-22 at 12 50 36 PM

This is the same as dartdoc main branch, so this PR did not change anything. It just struck me as a very low-contrasting grey-on-dark. Something to look into later. Thanks again!

@srawlins
Copy link
Member

Merge with main and re-upload?

@srawlins srawlins merged commit ced0209 into dart-lang:main Nov 23, 2024
7 checks passed
@parlough parlough deleted the misc/split-scss-into-files branch November 23, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants