Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict some validation to a single, target version of the analyzer package. #3778

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Jun 1, 2024

Restrict validation of runtime renderer files to a single, target version of
the analyzer package.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins changed the title Bump to analyzer 6.5.2 Restrict some validation to a single, target version of the analyzer package. Jun 7, 2024
@srawlins
Copy link
Member Author

srawlins commented Jun 7, 2024

CC @dart-lang/analyzer-team

@srawlins srawlins merged commit 3decf1e into dart-lang:main Jun 7, 2024
9 checks passed
@srawlins srawlins deleted the analyzer-6-5-2 branch June 7, 2024 14:01
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 10, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

collection (https://github.com/dart-lang/collection/compare/586a5e8..141d83a):
  141d83a  2024-06-07  Graciliano Monteiro Passos  `CanonicalizedMap`: added constructor `fromEntries`. (dart-archive/collection#347)

convert (https://github.com/dart-lang/convert/compare/302af1b..70940e3):
  70940e3  2024-06-10  Alex Li  ⚡ Upper-cast the return type of the decoder (dart-archive/convert#99)

dartdoc (https://github.com/dart-lang/dartdoc/compare/ddb8fb4..3decf1e):
  3decf1ed  2024-06-07  Sam Rawlins  Restrict validation of runtime renderer files to a single, target version of (dart-lang/dartdoc#3778)

ecosystem (https://github.com/dart-lang/ecosystem/compare/bc25c0c..865b2c5):
  865b2c5  2024-06-07  Devon Carew  update docs and metadata for package:sdk_triage_bot (dart-lang/ecosystem#266)
  268b516  2024-06-06  Devon Carew  initial version of a sdk issue triage bot (dart-lang/ecosystem#264)

http (https://github.com/dart-lang/http/compare/a3567f8..b522000):
  b522000  2024-06-08  Anikate De  fix inconsistent test server behavior (dart-lang/http#1227)

mime (https://github.com/dart-lang/mime/compare/8d2d559..4ca2f5e):
  4ca2f5e  2024-06-10  Sarah Zakarias  Add `topics` to `pubspec.yaml` (dart-archive/mime#126)

Change-Id: I6b6279a4ff0af5ba19cc3c4180389b949f48d623
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370660
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
srawlins added a commit to srawlins/dartdoc that referenced this pull request Jun 27, 2024
srawlins added a commit to srawlins/dartdoc that referenced this pull request Jun 27, 2024
srawlins added a commit that referenced this pull request Jun 27, 2024
4 cherry-picks + a version bump:

1. cherry-pick 8be17e1

    Fix flutter CI with re-internalized snippets tool (#3776)

2. cherry-pick ae1f184

    Use package:analyzer/source/source.dart (#3780)

3. cherry-pick db3a0ec

    Restrict validation of runtime renderer files to a single, target version of (#3778)
    the analyzer package.

4. cherry-pick 36db497

    Fix referencing an aliased type parameter. (#3784)

    What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such
    an alias. The fix is pretty simple, we just weren't previously handling this
    case, or being safe.

5. Bump to 8.0.9+1

---------

Co-authored-by: Konstantin Scheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants