Stop supporting '[this]' as a comment reference. #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
force-pushed
the
this
branch
2 times, most recently
from
beea410 to
fcf214d
Compare
The analyzer does not support it and does not intend to, so this change aligns with that effort. It makes analyzing the gap between analyzer and dartdoc easier as well. Fixes dart-lang#3761
|
CC @dart-lang/analyzer-team |
scheglov
approved these changes
Jun 18, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 20, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/818d1f5..6330a13): 6330a13e 2024-06-18 Sam Rawlins Declare local variables for the 'href' field, to promote and avoid printing 'null' (dart-lang/dartdoc#3788) 822ca007 2024-06-18 Sam Rawlins Stop supporting '[this]' as a comment reference. (dart-lang/dartdoc#3765) ecosystem (https://github.com/dart-lang/ecosystem/compare/8ada2ee..31148cd): 31148cd 2024-06-20 Devon Carew cosmetic update to the triager's comment format (dart-lang/ecosystem#273) glob (https://github.com/dart-lang/glob/compare/eaec6a4..6d3ba5e): 6d3ba5e 2024-06-20 Kevin Moore update lints (dart-lang/glob#95) logging (https://github.com/dart-lang/logging/compare/dbd6829..240ec33): 240ec33 2024-06-20 Kevin Moore Update lints dep, bump min SDK (dart-archive/logging#167) Change-Id: I2a691c3a4d02f55a625afaa855ab3e5aa60259c7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372520 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 9, 2024
Dartdoc broke this in dart-lang/dartdoc#3765.
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 9, 2024
Dartdoc broke this in dart-lang/dartdoc#3765.
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 9, 2024
Dartdoc broke this in dart-lang/dartdoc#3765.
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 9, 2024
Dartdoc broke this in dart-lang/dartdoc#3765.
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 9, 2024
Dartdoc broke this in dart-lang/dartdoc#3765.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analyzer does not support it and does not intend to, so this change aligns
with that effort. It makes analyzing the gap between analyzer and dartdoc
easier as well.
Fixes #3761
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.