Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move doc directive documentation to source code #3521

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

srawlins
Copy link
Member

This documentation currently lives in the wiki. However, we are planning to move the dartdoc code to the Dart SDK repo, and this wiki will be going away.

The text in this PR is more-or-less a dump of the wiki contents, and I tweaked the wording and typos a bit.

A full review of the text is fine, but I will likely respond for requests to document "more" or document "better" by writing in TODOs. I still encourage a full read of the text.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@parlough
Copy link
Member

parlough commented Oct 11, 2023

Cool!

For non-deprecated directives that are well supported, especially the ones now supported by the analyzer, I've long dreamt of their docs living on dart.dev (dart-lang/site-www#4347).

Perhaps a full review of the text can wait until that is worked on?

@srawlins
Copy link
Member Author

Thanks for the link @parlough !! I like this direction. I think we could maybe document each directive one-by-one, where we can focus on getting the text and semantics and support correct.

@parlough
Copy link
Member

parlough commented Oct 11, 2023

That sounds great to me.

I mostly delayed that work since I wasn't sure if and in what way each directive would stick around. Same for how the comment references could change with the import work.

@srawlins srawlins requested a review from bwilkerson October 12, 2023 14:35
Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

doc/directives.md Show resolved Hide resolved
doc/directives.md Show resolved Hide resolved
doc/directives.md Outdated Show resolved Hide resolved
@srawlins srawlins merged commit 8c10339 into dart-lang:main Oct 16, 2023
9 checks passed
@srawlins srawlins deleted the directives-doc branch October 16, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants