Do not crash when documenting an export with '//' #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
lgtm
Should we add a hint (in the analyzer) if import urls aren't normalized? Or, if there's some trivial normalization that could occur (if for some reason there are use cases for non-normalized urls)? So that would be for things like foo//bar.dart, or, foo/bar/../baz.dart.
|
I think dart-lang/sdk#57700 is such a request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/sdk#43467
When a library exports another with a double slash, like
export "src//a.dart";, dartdoc may crash.This avoids that crash. It's not a great fix, but can be addressed again later.