Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command line cleanup and link-to-remote by default #2187

Merged
merged 6 commits into from
Apr 21, 2020
Merged

command line cleanup and link-to-remote by default #2187

merged 6 commits into from
Apr 21, 2020

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Apr 21, 2020 •
edited
Loading

Fixes #2141.

This is a batch of usability cleanups for Dartdoc.

  • --link-to-remote is now the default. This should provide output similar to pub for users in the base case.
  • Updated generated URIs for Flutter SDK, Dart SDK, and pub packages to their new .dev versions.
  • --show-progress is now the default on interactive terminals and features a spinner now instead of just printing periods.
  • Fixed a bug in isCanonical that could result in hrefs being generated for private members if asked for explicitly
  • Fixed all the documentation errors and warnings inside dartdoc itself, so it documents itself cleanly.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 21, 2020
devoncarew
devoncarew approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Apr 21, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 91.626% when pulling 55a6d35 on enable-link-to-remote into d647980 on master.

@jcollins-g jcollins-g merged commit 611b675 into master Apr 21, 2020
@jcollins-g jcollins-g deleted the enable-link-to-remote branch April 21, 2020 20:41
@CaptainIRS CaptainIRS mentioned this pull request Mar 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

@MichaelRFairhurst MichaelRFairhurst Awaiting requested review from MichaelRFairhurst

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dartdoc over Flutter project is trying to parse all the Flutter source files.
4 participants
@jcollins-g @coveralls @devoncarew @googlebot