Fix the flutter SDK search box loading on non-root pages with --use-base-href #2158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2157.
This combines the attempts in #2118 and #2125 into something that works for the case in Flutter where they've changed the directory level of everything except the index to one down (under flutter/), and rewritten the href on the index page accordingly. I didn't notice this as the
serve-flutter-docs
grinder doesn't do that hack and I didn't stop to think about the implications of that at the time... Also,serve-flutter-docs
doesn't use --use-base-href so a manual test verifying the search box worked with that wouldn't have helped in any event.I'm open to a better way of doing this in javascript, but I have tried several alternatives (including trying to read the base tag directly) and this seems to be the one that works reliably.