Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter error display tests #1895

Merged
merged 6 commits into from
Jan 11, 2019
Merged

Parameter error display tests #1895

merged 6 commits into from
Jan 11, 2019

Conversation

jcollins-g
Copy link
Contributor

Fixes a minor issue and adds tests for situations where passed parameters can raise exceptions into bin/dartdoc.dart.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 9, 2019
@jcollins-g jcollins-g requested a review from devoncarew January 11, 2019 01:45
@coveralls
Copy link

coveralls commented Jan 11, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 93.789% when pulling 1759e57 on parameter-error-display-tests into 604767f on master.

@jcollins-g jcollins-g merged commit 10f30e8 into master Jan 11, 2019
@jcollins-g jcollins-g deleted the parameter-error-display-tests branch January 11, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @devoncarew @googlebot