Remove mustache4dart copy inside dartdoc and use 'mustache' pub package #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will have to do the DEPS/mirrors dance with the SDK build but I think it is worth it to clean up dartdoc's dependencies. |
devoncarew
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mustache4dart hasn't been fully supported on Dart 2 for a while, so I looked into porting to a different mustache implementation. It turned out not to be that hard, and this mustache implementation is slightly faster, published with full Dart 2 compatibility, while being less forgiving of Dartdoc's malformed templates.
I've fixed the bugs in our templates here and with one small feature to the mustache library
(xxgreg/mustache#41) the port is good to go.