Performance improvements for documentation generation #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
approved these changes
Nov 14, 2018
| final macroRegExp = new RegExp(r'<dartdoc-html>([a-f0-9]+)</dartdoc-html>'); | ||
| return rawDocs.replaceAllMapped(macroRegExp, (match) { | ||
|
|
||
| return rawDocs.replaceAllMapped(htmlInjectRegExp, (match) { |
There was a problem hiding this comment.
Thanks: much better name.
| r'[ ]*{@inject-html\s*}([\s\S]+?){@end-inject-html}[ ]*\n?', | ||
| multiLine: true); | ||
| return rawDocs.replaceAllMapped(templateRegExp, (match) { | ||
| return rawDocs.replaceAllMapped(htmlRegExp, (match) { |
There was a problem hiding this comment.
Heh. I guess I haven't been paying too much attention to renaming things I cut and paste...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precache local documentation only when there's a chance it is necessary, don't block on I/O for deleting temporary directories, and eliminate inefficient uses of string splitting and joining. Combined impact approximately 5% performance improvement with asserts enabled for Flutter.