Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include/exclude to supported config options #1700

Merged
merged 5 commits into from
May 29, 2018

Conversation

jcollins-g
Copy link
Contributor

Add a test for include/exclude, and fixed a bug where you couldn't exclude something that was already included (exclude now overrides include).

@googlebot googlebot added the cla: yes Google CLA check succeeded. label May 25, 2018
Copy link
Contributor

@MichaelRFairhurst MichaelRFairhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and nice test coverage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants