Add support for a dartdoc_options.yaml. #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e truly need this
devoncarew
approved these changes
Mar 19, 2018
lib/src/dartdoc_options.dart
Outdated
|
|
||
| import 'logging.dart'; | ||
|
|
||
| Map<String, DartdocOptions> _dartdocOptionsCache = {}; |
lib/src/dartdoc_options.dart
Outdated
|
|
||
| import 'dart:io'; | ||
|
|
||
| import 'package:path/path.dart' as p; |
There was a problem hiding this comment.
I personally avoid single letter as imports
There was a problem hiding this comment.
Yes, they're not great. I just obliterated them all, replacing the inconsistent imports of path as path/p/etc with "pathLib".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly scaffolding and basic loading tests for a dartdoc options file. This doesn't port any existing options over, instead creating only one to support #1610. Porting command line options over and making the dartdoc_options file interact with command line options will be done later.